docs: fix stale claims that Go is unsupported/roadmap-only#14
Merged
Conversation
flaglint-go shipped (v0.1.0/v0.1.1) as a separate, real CLI months after these pages were written — they still said Go SDK usage was entirely unsupported/roadmap-only via a tree-sitter-go plan that was never built. - supported-scope.md: split the "Go, Java, Python..." row; Go now points to flaglint-go's own supported-scope page instead of being lumped in with genuinely-unsupported languages. - safety-model.md: clarified this page is specifically about flaglint-js's migrate --apply (which flaglint-go doesn't have), not a blanket "Go is unsupported by FlagLint" statement. - changelog.md: updated the ADR 006 (Go language support, PROPOSED) entry to note it was superseded — Go support shipped as flaglint-go, built on native go/parser instead of the originally-proposed tree-sitter-go. Links to the new /docs/go/ section (landing in a follow-up PR) — the actual Go docs content doesn't exist yet, so those links 404 until that PR merges. Signed-off-by: Krishan Kant Sharma <krishansharma0327@gmail.com>
Deploying flaglint with
|
| Latest commit: |
79794b3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82f08f29.flaglint.pages.dev |
| Branch Preview URL: | https://docs-fix-stale-go-unsupporte.flaglint.pages.dev |
📝 WalkthroughWalkthroughDocumentation updates clarify that the safety-model and supported-scope pages apply specifically to the flaglint-js (JavaScript/TypeScript) CLI, separating Go SDK coverage into the flaglint-go project. The changelog entry for ADR 006 is updated to reflect the actual shipped Go implementation approach. ChangesDocs scope clarification
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/content/docs/docs/concepts/safety-model.md`:
- Around line 4-8: The safety-model docs page currently links to a Go docs
target that does not exist in this change, so update the content in the
safety-model markdown to avoid shipping dead `/docs/go/...` links. Gate or defer
the Go documentation reference in this page until the Go docs subtree is part of
the same PR, and apply the same treatment to the later Go docs link(s)
referenced in the file so both `flaglint-go` mentions only point to existing
pages.
In `@src/content/docs/docs/reference/changelog.md`:
- Around line 78-83: The changelog entry in the ADR 006 section should not
publish a broken internal link to the nonexistent Go docs page. Update the
markdown in the changelog to either remove the `/docs/go/` link or replace it
with a non-link placeholder until the target page exists, keeping the
surrounding text in the same `ADR 006 — Go language support` entry.
In `@src/content/docs/docs/reference/supported-scope.md`:
- Around line 4-8: The supported-scope doc currently links to the Go docs before
those routes exist, causing broken navigation. Update the content in the
supported-scope page so the Go CLI reference link is gated or omitted until the
Go docs section is actually added, using the existing supported-scope page
content as the place to adjust the cross-link.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 72a39ec3-5fa3-4875-8731-eac33f02857a
📒 Files selected for processing (3)
src/content/docs/docs/concepts/safety-model.mdsrc/content/docs/docs/reference/changelog.mdsrc/content/docs/docs/reference/supported-scope.md
Comment on lines
+4
to
+8
| lastUpdated: 2026-07-06 | ||
| --- | ||
|
|
||
| This page covers **flaglint-js**'s `migrate --apply` rewrite safety model, which is specific to the JavaScript/TypeScript CLI — flaglint-go does not have an automated migration/rewrite command (audit, scan, and validate only). See [flaglint-go's concepts docs](/docs/go/concepts/identity-model/) for the Go CLI's own safety guarantees. | ||
|
|
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'Root files mentioning the Go concepts path:\n'
rg -n "/docs/go/concepts/identity-model/|flaglint-go's concepts docs|concepts/identity-model" src content docs . --glob '!**/node_modules/**' || true
printf '\nCandidate files under docs:\n'
git ls-files 'src/content/docs/**' | sed -n '1,200p'
printf '\nCheck whether the referenced Go docs file exists:\n'
fd -a 'identity-model\.md$|identity-model/index\.md$' src/content/docs content/docs docs 2>/dev/null || true
fd -a 'safety-model\.md$' src/content/docs content/docs docs 2>/dev/null || trueRepository: flaglint/flaglint.dev
Length of output: 3885
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Safety model excerpt:"
cat -n src/content/docs/docs/concepts/safety-model.md | sed -n '1,120p'
echo
echo "Find any Go docs files in this subtree:"
git ls-files 'src/content/docs/go/**' 'src/content/docs/docs/go/**' | sed -n '1,200p'
echo
echo "Search for the referenced route in the repo:"
rg -n --hidden --glob '!**/node_modules/**' --glob '!**/.git/**' "/docs/go/concepts/identity-model/|identity-model" src/content/docsRepository: flaglint/flaglint.dev
Length of output: 10234
Gate the Go docs links on the Go docs section PR. The /docs/go/... target isn’t present here, so this page would ship a dead link unless the Go docs subtree lands with it. Also applies to lines 50-51.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/content/docs/docs/concepts/safety-model.md` around lines 4 - 8, The
safety-model docs page currently links to a Go docs target that does not exist
in this change, so update the content in the safety-model markdown to avoid
shipping dead `/docs/go/...` links. Gate or defer the Go documentation reference
in this page until the Go docs subtree is part of the same PR, and apply the
same treatment to the later Go docs link(s) referenced in the file so both
`flaglint-go` mentions only point to existing pages.
Comment on lines
+78
to
+83
| - **ADR 006 — Go language support** (PROPOSED, later superseded) — | ||
| tree-sitter-go parser design, import tracing for `go-server-sdk`, go.mod | ||
| boundary handling, 6-phase plan. Go support ultimately shipped as a | ||
| separate project, [flaglint-go](https://github.com/flaglint/flaglint-go), | ||
| built around Go's native `go/parser`/`go/ast` instead of tree-sitter — see | ||
| [flaglint-go's docs](/docs/go/). |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
git ls-files src/content/docs | sed -n '1,200p'Repository: flaglint/flaglint.dev
Length of output: 2830
🏁 Script executed:
rg -n --hidden --glob '!node_modules' --glob '!dist' --glob '!build' '/docs/go/|flaglint-go|Go language support|go/parser|go/ast' src/content/docsRepository: flaglint/flaglint.dev
Length of output: 1646
🏁 Script executed:
git ls-files | sed -n '1,200p'Repository: flaglint/flaglint.dev
Length of output: 3564
🏁 Script executed:
sed -n '1,220p' public/_redirects && printf '\n---\n' && sed -n '1,240p' src/content.config.ts && printf '\n---\n' && sed -n '1,220p' astro.config.mjsRepository: flaglint/flaglint.dev
Length of output: 7216
Hold the /docs/go/ link for now
src/content/docs/docs/reference/changelog.md:83 points to a page that doesn’t exist in this site yet, so this changelog entry would publish a 404.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/content/docs/docs/reference/changelog.md` around lines 78 - 83, The
changelog entry in the ADR 006 section should not publish a broken internal link
to the nonexistent Go docs page. Update the markdown in the changelog to either
remove the `/docs/go/` link or replace it with a non-link placeholder until the
target page exists, keeping the surrounding text in the same `ADR 006 — Go
language support` entry.
Comment on lines
+4
to
+8
| lastUpdated: 2026-07-06 | ||
| --- | ||
|
|
||
| This page covers **flaglint-js**, the JavaScript/TypeScript CLI. For the Go CLI's supported scope, see [flaglint-go: Supported Scope](/docs/go/reference/supported-scope/). | ||
|
|
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Map the docs-related files and routes.
git ls-files | rg '^(src/content/docs|astro|docs|src/pages|src/content).*$'
# Look for references to the Go docs base path and supported-scope page.
rg -n "/docs/go/|supported-scope|flaglint-go" src/content docs astro src/pages . 2>/dev/null || trueRepository: flaglint/flaglint.dev
Length of output: 6898
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the docs collection and any routing/redirects for a Go docs section.
sed -n '1,220p' astro.config.mjs
printf '\n--- src/content.config.ts ---\n'
sed -n '1,220p' src/content.config.ts
printf '\n--- public/_redirects ---\n'
sed -n '1,120p' public/_redirects 2>/dev/null || true
printf '\n--- go docs files ---\n'
fd -t f '.*' src/content/docs | rg '/go/'Repository: flaglint/flaglint.dev
Length of output: 7287
Gate the Go docs links until that section exists.
/docs/go/ and /docs/go/reference/supported-scope/ aren’t routed in this site yet, so they’ll 404 until the Go docs pages land.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/content/docs/docs/reference/supported-scope.md` around lines 4 - 8, The
supported-scope doc currently links to the Go docs before those routes exist,
causing broken navigation. Update the content in the supported-scope page so the
Go CLI reference link is gated or omitted until the Go docs section is actually
added, using the existing supported-scope page content as the place to adjust
the cross-link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supported-scope.md: split the "Go, Java, Python..." row — Go now points to flaglint-go's own supported-scope page.safety-model.md: clarified this page is specifically about flaglint-js'smigrate --apply(which flaglint-go doesn't have), not a blanket "Go unsupported by FlagLint" statement.changelog.md: updated the ADR 006 (Go language support, PROPOSED) entry to note it was superseded by flaglint-go, built on nativego/parserinstead of the originally-proposed tree-sitter-go.This links to a new
/docs/go/section that doesn't exist yet (landing in a follow-up PR). Sincedeploy.ymlpushes straight to Cloudflare Pages on merge tomain, merging this alone would put live 404 links on the site. Merge the Go docs section PR first, then this one.Test plan
npm run build— clean, no errorsSummary by CodeRabbit