docs: refresh flaglint-go pages — 6 listed gaps are resolved, add --strict-types and baseline counts#21
Conversation
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughDocumentation-only update to flaglint-go docs introducing a new opt-in ChangesGo docs updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying flaglint with
|
| Latest commit: |
a440782
|
| Status: | ⚡️ Build in progress... |
…trict-types and baseline counts Every identity-resolution gap listed as "not resolved yet" on the flaglint-go Limitations and Supported Scope pages has actually been closed (verified directly against the flaglint-go issue tracker): chained factory-call-then-method (#20), method values (#6), interface satisfaction (#15), block-scoped shadowing (#5), factory returning a wrapper type (#16), and nested go.mod files (#17). These pages were last updated right before that work landed. - limitations.md / supported-scope.md: mark all six as resolved (noting which layer resolves each — Phase 1 default vs. opt-in --strict-types), add two newer Phase-1 mechanisms these pages never mentioned at all (a struct field declared *ld.LDClient with no observed construction, and a composite literal directly initializing a package-level var), and state plainly that zero identity-resolution gaps are currently tracked. - identity-model.md: add worked examples for both newer Phase-1 mechanisms above, plus a new "Phase 2 — --strict-types" section (interface satisfaction, transitive factory wrapping, cross-function method-value forwarding) that didn't exist on this page at all before. - index.md: same corrections to the "what flaglint-go does/doesn't do" summary — it previously named method values and interface satisfaction as open gaps. - cli/{scan,audit,validate}.md: --strict-types wasn't documented as a flag anywhere on the site despite being available on all three commands since it shipped; added to each page's options table. audit.md's baseline JSON example was also missing the "schemaVersion" and "counts" fields flaglint-go now emits; validate.md's Baseline Mode section gains a note on what "counts" actually catches (a brand-new duplicate of an already-baselined call, not just a brand-new fingerprint). Verified: `npm run build` completes cleanly (90 pages), spot-checked the rendered Limitations page's output directly. Signed-off-by: Krishan Kant Sharma <krishansharma0327@gmail.com>
flaglint
force-pushed
the
docs/go-refresh-resolved-gaps
branch
from
bd2b38b to
a440782
Compare
2 participants
Summary
Every identity-resolution gap listed as "not resolved yet" on the flaglint-go docs pages has actually been closed — verified directly against the flaglint-go issue tracker:
--strict-types)--strict-types)go.modfilesThese pages were dated right before that work landed, so the site was significantly understating what flaglint-go can currently do.
Changes
--strict-types), add two newer Phase-1 mechanisms these pages never mentioned at all (a struct field declared*ld.LDClientwith no observed construction anywhere, and a composite literal directly initializing a package-levelvar), and state plainly that zero identity-resolution gaps are currently tracked.--strict-types" section (interface satisfaction, transitive factory wrapping, cross-function method-value forwarding) that didn't exist on this page before.--strict-typeswasn't documented as a flag anywhere on the site despite being available on all three commands since it shipped — added to each page's options table.audit.md's baseline JSON example was also missing theschemaVersion/countsfields flaglint-go now emits;validate.md's Baseline Mode section gains a note on whatcountsactually catches (a brand-new duplicate of an already-baselined call, not just a brand-new fingerprint).Verification
npm run buildcompletes cleanly (90 pages built), spot-checked the rendered Limitations page's actual output.Summary by CodeRabbit
--strict-typesoption.