Update generated gem bundler dependency to >= 1.0 - #11
Open
AndyObtiva wants to merge 3 commits into
Open
Conversation
AndyObtiva
force-pushed
the
juwelier
branch
2 times, most recently
from
January 3, 2021 04:11
4663ab1 to
8bb5fd8
Compare
AndyObtiva
changed the title
This was referenced Jan 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that generated gem Bundler dependency is pinned to 1.0 (an old version), so I relaxed to ">= 1.0"
Also, fixed a broken test and a dependency on test_construction.
Cheers.
p.s. if you need maintainers, I’d be happy to help maintain Juwelier and Jeweler since I’ve been relying on since the mid 2000s and autoinstall for users of Glimmer DSL for SWT during scaffolding.