Skip to content

Restore the media URL transition and stabilize its empty state - #142

Merged
flamboh merged 1 commit into
mainfrom
codex/remove-empty-selection-url-import
Aug 3, 2026
Merged

flamboh merged 1 commit into
mainfrom
codex/remove-empty-selection-url-import

Conversation

@flamboh

@flamboh flamboh commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

Keeps URL importing fully available while refining the media bar across its visible states:

  • Removes only the “or import from a url” divider from the populated-library empty-selection screen.
  • Keeps the selected-track and empty-selection bars at the same width; the initial landing bar remains compact.
  • Restores the shared-element transition so the same URL input glides and resizes between landing, loaded-editor, and empty-editor layouts.
  • Preserves reduced-motion behavior and the intentional settings-screen unmount.

Root cause

The transition regression landed in f716382 through PR #135; its parent 412afb3 is the last known-good main commit. That refactor correctly lifted the URL-entry controller so text survived layout changes, but it also split one persistent MediaUrlEntry into mutually exclusive mounts and removed the geometry animation. There was no motion-related product decision in the PR, so this restores the lost behavior while keeping the lifted state.

Human review

  1. Start with an empty library. Confirm the compact URL import field and “or import from a url” divider are still present.
  2. Add a track. The same URL field should glide to the wider media bar at the bottom of the editor instead of disappearing and reappearing.
  3. Clear the track selection. Confirm the URL field remains editable, the divider is absent, and the media bar keeps the same width.
  4. Enter text, open Settings, then return. The URL field should restore its text; it is intentionally unmounted while Settings is open.
  5. Repeat at mobile and intermediate widths. Check that the bar fits without overlapping the dropzone.
  6. With reduced motion enabled, state changes should settle immediately without the shared-element animation.

Review considerations: the landing layout intentionally remains narrower, while both editor states share the wider width. Motion animates real position and width rather than scaling the form, keeping text and controls crisp.

Verification

  • bunx vp check
  • bun run test — 102 files, 631 tests passed
  • bun run build
  • bun run test:e2e -- --project=chromium tests/e2e/settings-transition.spec.ts — 10 passed
  • Deterministic E2E coverage verifies DOM identity plus intermediate geometry during the landing-to-editor transition
  • Unit coverage verifies real position/width keyframes without transform scaling
  • Impeccable UI detector — no findings

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 30, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tagium 4ad8a75 Commit Preview URL

Branch Preview URL
Aug 03 2026, 07:52 PM

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 4ad8a75.

@flamboh
flamboh force-pushed the codex/remove-empty-selection-url-import branch from 6a4c4f8 to 51462c0 Compare August 3, 2026 19:13
@flamboh flamboh changed the title Hide URL import when no track is selected Remove URL import label when no track is selected Aug 3, 2026
@flamboh
flamboh force-pushed the codex/remove-empty-selection-url-import branch from 51462c0 to 164ec7e Compare August 3, 2026 19:23
@flamboh flamboh changed the title Remove URL import label when no track is selected Stabilize URL import bar when no track is selected Aug 3, 2026
@flamboh
flamboh force-pushed the codex/remove-empty-selection-url-import branch from 164ec7e to 4ad8a75 Compare August 3, 2026 19:51
@flamboh flamboh changed the title Stabilize URL import bar when no track is selected Restore the media URL transition and stabilize its empty state Aug 3, 2026
@flamboh
flamboh merged commit d744cb6 into main Aug 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant