Restore the media URL transition and stabilize its empty state - #142
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tagium | 4ad8a75 | Commit Preview URL Branch Preview URL |
Aug 03 2026, 07:52 PM |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
flamboh
force-pushed
the
codex/remove-empty-selection-url-import
branch
from
August 3, 2026 19:13
6a4c4f8 to
51462c0
Compare
flamboh
force-pushed
the
codex/remove-empty-selection-url-import
branch
from
August 3, 2026 19:23
51462c0 to
164ec7e
Compare
flamboh
force-pushed
the
codex/remove-empty-selection-url-import
branch
from
August 3, 2026 19:51
164ec7e to
4ad8a75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keeps URL importing fully available while refining the media bar across its visible states:
Root cause
The transition regression landed in
f716382through PR #135; its parent412afb3is the last known-good main commit. That refactor correctly lifted the URL-entry controller so text survived layout changes, but it also split one persistentMediaUrlEntryinto mutually exclusive mounts and removed the geometry animation. There was no motion-related product decision in the PR, so this restores the lost behavior while keeping the lifted state.Human review
Review considerations: the landing layout intentionally remains narrower, while both editor states share the wider width. Motion animates real position and width rather than scaling the form, keeping text and controls crisp.
Verification
bunx vp checkbun run test— 102 files, 631 tests passedbun run buildbun run test:e2e -- --project=chromium tests/e2e/settings-transition.spec.ts— 10 passed