fix(CODEWIKI-006): CU-86akbhg0r 2 review findings across 2 files - #41
Conversation
| @@ -13,12 +13,6 @@ | |||
| import logging | |||
| import sys | |||
|
|
|||
There was a problem hiding this comment.
🦩 🟠 Third-party logger suppression duplicated in non-entry-point module doc_generator.py
Removed the module-level duplicate third-party logger suppression block (logging.getLogger("httpx"/"openai"/"openai._base_client"/"anthropic").setLevel(logging.WARNING)) and its comment from the top of codewiki/cli/adapters/doc_generator.py, since this is not the entry-point module per CODEWIKI-006. The import logging statement was kept since logging is still used extensively throughout the file (e.g., _configure_backend_logging, various logger.info/logger.error calls). This centralizes the suppression to the actual entry point (main.py), removing the duplication called out in the finding. Residual risk: this file no longer independently guarantees suppressed httpx/openai/anthropic logs if invoked in a code path that bypasses the entry point's setup_logging(); confirming that all invocation paths go through the entry point is outside this file's visibility.
🤖 Prompt for AI agents
In codewiki/cli/adapters/doc_generator.py around line 15, review and complete this code-review fix: Third-party logger suppression duplicated in non-entry-point module doc_generator.py.
What the draft fix changed: Removed the module-level duplicate third-party logger suppression block (`logging.getLogger("httpx"/"openai"/"openai._base_client"/"anthropic").setLevel(logging.WARNING)`) and its comment from the top of `codewiki/cli/adapters/doc_generator.py`, since this is not the entry-point module per CODEWIKI-006. The `import logging` statement was kept since `logging` is still used extensively throughout the file (e.g., `_configure_backend_logging`, various `logger.info`/`logger.error` calls). This centralizes the suppression to the actual entry point (main.py), removing the duplication called out in the finding. Residual risk: this file no longer independently guarantees suppressed httpx/openai/anthropic logs if invoked in a code path that bypasses the entry point's setup_logging(); confirming that all invocation paths go through the entry point is outside this file's visibility.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟡 85 medium — react 👍/👎 to teach the reviewer
| logger = create_logger(verbose=verbose) | ||
| start_time = time.time() | ||
|
|
||
| # Suppress verbose third-party library logs | ||
| logging.getLogger("httpx").setLevel(logging.WARNING) | ||
| logging.getLogger("openai").setLevel(logging.WARNING) | ||
| logging.getLogger("openai._base_client").setLevel(logging.WARNING) | ||
| logging.getLogger("anthropic").setLevel(logging.WARNING) | ||
|
|
||
| try: | ||
| # Pre-generation checks | ||
| logger.step("Validating configuration...", 1, 4) |
There was a problem hiding this comment.
🦩 🟠 Third-party logger suppression duplicated again in generate.py command handler
Removed the duplicated third-party logger suppression block (logging.getLogger("httpx"/"openai"/"openai._base_client"/"anthropic").setLevel(logging.WARNING)) from generate_command in codewiki/cli/commands/generate.py, immediately after start_time = time.time(). Per CODEWIKI-006 this suppression should occur exactly once at the application entry point (already present in doc_generator.py), so the redundant copy here is deleted rather than duplicated. The logging import is left in place since it is unused elsewhere in this file now, but removing it was not required by the finding and leaving it avoids risking an accidental break if it's referenced indirectly; a reviewer may want to drop the now-unused import logging as a small follow-up cleanup. Risk: if the entry-point suppression in doc_generator.py is not actually invoked before this command handler runs in some invocation path, third-party WARNING logs could reappear here — this was not verified end-to-end since only this file was in scope.
🤖 Prompt for AI agents
In codewiki/cli/commands/generate.py around line 199, review and complete this code-review fix: Third-party logger suppression duplicated again in generate.py command handler.
What the draft fix changed: Removed the duplicated third-party logger suppression block (`logging.getLogger("httpx"/"openai"/"openai._base_client"/"anthropic").setLevel(logging.WARNING)`) from `generate_command` in `codewiki/cli/commands/generate.py`, immediately after `start_time = time.time()`. Per CODEWIKI-006 this suppression should occur exactly once at the application entry point (already present in `doc_generator.py`), so the redundant copy here is deleted rather than duplicated. The `logging` import is left in place since it is unused elsewhere in this file now, but removing it was not required by the finding and leaving it avoids risking an accidental break if it's referenced indirectly; a reviewer may want to drop the now-unused `import logging` as a small follow-up cleanup. Risk: if the entry-point suppression in `doc_generator.py` is not actually invoked before this command handler runs in some invocation path, third-party WARNING logs could reappear here — this was not verified end-to-end since only this file was in scope.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟡 80 medium — react 👍/👎 to teach the reviewer
|
Hold: this removes the only third-party log suppression on the CLI path. The PR deletes these from both logging.getLogger("httpx").setLevel(logging.WARNING)
logging.getLogger("openai").setLevel(logging.WARNING)
logging.getLogger("openai._base_client").setLevel(logging.WARNING)
logging.getLogger("anthropic").setLevel(logging.WARNING)The identical block still exists in The finding itself is legitimate — module-level |
Deleting the setLevel() calls was right in principle - a module-level side effect that fires on import is invisible from the call site - but it left nothing suppressing them on the CLI path. The identical block in src/be/main.py does not help: that module is not among the 49 reachable from cli/commands/generate.py, so after this branch 'python -m codewiki generate' logs one httpx INFO line per LLM request, and the doc pipeline runs it with --verbose. Reintroduce the suppression as quiet_third_party_loggers(), called from create_logger(), which generate_command already invokes before any generation work. Same effect, at an explicit call site instead of an import side effect. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Closes 2 review findings across 2 files.
Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.
codewiki/cli/adapters/doc_generator.py:15codewiki/cli/commands/generate.py:199What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.
Run: https://product-hub.flamingo.so/admin/code-review
Run id:
bef4f5a8-e7f3-478b-8731-2becca2de658Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.
ClickUp task: CU-86akbhg0r Code review fixes: CodeWiki backend and CLI review findings (5 PRs)