fix(CODEWIKI-007): CU-86akbhhru Config constructed via Config.from_args at call site inside background worker, bypassing web-app factory

[flamingo]

Closes findings from rule CODEWIKI-007 — Config constructed via Config.from_args at call site inside background worker, bypassing web-app factory.

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

#	Fix confidence	Finding	Location
1	🔴 45 low — review closely	Config constructed via Config.from_args at call site inside background worker, bypassing web-app factory	codewiki/src/fe/background_worker.py:207

What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.

---

Run: https://product-hub.flamingo.so/admin/code-review
Run id: 2cc7a212-e9ac-481a-a76e-5f03d762c00c

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

ClickUp task: CU-86akbhhru CodeWiki backend and CLI review findings (12 PRs)

[flamingo]

🦩 What this fix changed, finding by finding

1 finding(s) fixed in this draft — 1 explained inline on the diff; 1 low-confidence hunk(s) need close review before merging.

[flamingo]

🦩 🔴 Config constructed via Config.from_args at call site inside background worker, bypassing web-app factory

In _process_job, replaced the argparse.Namespace + Config.from_args workaround and post-construction config.docs_dir mutation with a call to a new Config.from_web_job(repo_path=temp_repo_dir, docs_dir=docs_dir) classmethod factory, removing the now-unused import argparse. This change assumes such a factory will be added to codewiki/src/config.py, which is outside this file and was not provided — without adding from_web_job to the Config class, this file will raise AttributeError at runtime. A complete fix requires adding the Config.from_web_job classmethod in codewiki/src/config.py mirroring from_args's validation logic but accepting an explicit docs_dir parameter instead of mutating it post-hoc.

🤖 Prompt for AI agents

In codewiki/src/fe/background_worker.py around line 207, review and complete this code-review fix: Config constructed via Config.from_args at call site inside background worker, bypassing web-app factory.
What the draft fix changed: In `_process_job`, replaced the `argparse.Namespace` + `Config.from_args` workaround and post-construction `config.docs_dir` mutation with a call to a new `Config.from_web_job(repo_path=temp_repo_dir, docs_dir=docs_dir)` classmethod factory, removing the now-unused `import argparse`. This change assumes such a factory will be added to `codewiki/src/config.py`, which is outside this file and was not provided — without adding `from_web_job` to the `Config` class, this file will raise `AttributeError` at runtime. A complete fix requires adding the `Config.from_web_job` classmethod in `codewiki/src/config.py` mirroring `from_args`'s validation logic but accepting an explicit `docs_dir` parameter instead of mutating it post-hoc.
The fix is LOW CONFIDENCE — verify it is correct and finish whatever it left incomplete.

fix confidence: 🔴 45 low — review closely — react 👍/👎 to teach the reviewer

[michaelassraf]

Blocking: Config.from_web_job does not exist.

config = Config.from_web_job(repo_path=temp_repo_dir, docs_dir=docs_dir)

Config defines only from_args, from_cli, and from_config_manager. I checked main and every branch in this batch (including #39 and #49, the other two that touch config.py) — nothing adds from_web_job. This is an AttributeError on the first job the web-app background worker processes.

The intent is right — building a Config through a fake argparse.Namespace at a call site is the thing worth fixing. Please add the from_web_job classmethod to codewiki/src/config.py in this PR.

Note #52 has since merged and also touches background_worker.py, so this will need a rebase.