fix: test_clustering_forced.py passes kwargs Config.from_cli does not accept - #58
Merged
Merged
Conversation
… accept Config.from_cli has no dependency_graph_dir or docs_dir parameter, so the call was a TypeError. It reached main because #35 and #46 changed the same construction differently and git auto-merged to #35's from_cli form without raising a conflict, and my verification pass only checked direct Config(...) calls - it did not look at Config.from_* factories at all. Restore the direct Config(...) construction #46 landed, which takes all sixteen kwargs including the two output directories this test relies on. Every Config construction site in the repo is now checked both ways - direct construction against the dataclass fields, and each from_* call against the factory's real signature. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config.from_clihas nodependency_graph_dirordocs_dirparameter, so the call intest_clustering_forced.pyis aTypeError.It reached
mainbecause #35 and #46 changed the same construction differently and git auto-merged to #35'sfrom_cliform without raising a conflict — and the verification pass on those PRs only checked directConfig(...)calls, notConfig.from_*factories.Restores the direct
Config(...)construction #46 landed, which accepts all sixteen kwargs including the two output directories the test relies on.Verified: every Config construction site in the repo now checks out both ways — direct construction against the dataclass fields, and each
from_*call against the factory's real signature.🤖 Generated with Claude Code