helm: add Redis TLS to the fleet chart, mirroring database.tls - #179
Open
yaroslavmokflmg wants to merge 1 commit into
Open
yaroslavmokflmg wants to merge 1 commit into
yaroslavmokflmg wants to merge 1 commit into
Conversation
🦩 Flamingo Code ReviewNo findings on the current head. Mode: advisory Need another pass? Commits pushed after this review are not reviewed automatically.
Prefer typing? Comment React 👍/👎 on inline comments to teach the reviewer. Started 2026-09-15 20:43 UTC · updated 2026-09-15 20:43 UTC · workflow run |
yaroslavmokflmg
force-pushed
the
feat/redis-tls
branch
from
September 15, 2026 20:47
37a4cdb to
6cd37a4
Compare
A managed Redis answers only over TLS and signs with a private CA, so the client has to be handed one. cache.tls follows database.tls exactly, and is wired into both workloads that open a Redis connection: the server deployment and the vuln-processing cron. Off by default, so an in-cluster Redis keeps connecting in plain text.
yaroslavmokflmg
force-pushed
the
feat/redis-tls
branch
from
September 15, 2026 20:48
6cd37a4 to
6a1ab83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A managed Redis (Memorystore, ElastiCache) accepts only TLS connections and signs its certificate
with a private CA. The chart had no way to turn TLS on, and no way to hand the client a CA, so the
only Redis it could reach was a plaintext in-cluster one.
What
cache.tlsmirrorsdatabase.tlsone for one — same shape, same whole-Secret mount, samefallback rules.
cache.tls.enabledFLEET_REDIS_USE_TLScache.tls.caCertKeyFLEET_REDIS_TLS_CA/secrets/redis/<key>cache.tls.serverNameFLEET_REDIS_TLS_SERVER_NAMEcache.tls.existingSecret/secrets/redis; falls back tocache.secretNameBoth workloads that open a Redis connection are covered: the Fleet server and the vuln-processing
cron. Nothing else is needed for a clustered managed Redis —
redis_cluster_follow_redirectionsdefaults to true, so MOVED replies from a discovery endpointare followed.
Files
charts/fleet/values.yamlcache.tlsblockcharts/fleet/templates/deployment.yamlcharts/fleet/templates/vulnprocessing/cronjob.yamlopenframe/docs/helm-chart.mdCompatibility
Default is
enabled: false, so an in-cluster Redis renders byte for byte as before.