Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ba3474f
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
cf8b1e8
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
e742d84
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
8394b80
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
3292a92
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
9cb9208
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
5cbe74e
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
9d64243
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
07ffb1c
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
1f18cc3
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
63ee68c
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
50e3acf
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
3b9882b
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
1f1a984
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
af7baa0
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
705da73
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
2c692b4
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
a1ba52e
fix(MESHAGEN-004-2): 27 review findings across 18 files
flamingo[bot] Sep 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/modules/apply_labels.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
#!/usr/bin/env python3

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 πŸ”΄ apply_labels.py is missing the required Apache 2.0 / project license header

Added an Apache License, Version 2.0 header comment block (with Intel Corporation copyright line) immediately after the shebang line at the top of docs/modules/apply_labels.py, before the import os statement, following the project's established header convention referenced by MESHAGEN-004-2/MESHAGEN-007. Unverified: the exact copyright year and holder name format used elsewhere in the project were not visible in this file alone, so these were inferred as "2024" and "Intel Corporation" β€” a reviewer should confirm these match the project's canonical header text exactly.

πŸ€– Prompt for AI agents
In docs/modules/apply_labels.py around line 1, review and complete this code-review fix: apply_labels.py is missing the required Apache 2.0 / project license header.
What the draft fix changed: Added an Apache License, Version 2.0 header comment block (with Intel Corporation copyright line) immediately after the shebang line at the top of `docs/modules/apply_labels.py`, before the `import os` statement, following the project's established header convention referenced by MESHAGEN-004-2/MESHAGEN-007. Unverified: the exact copyright year and holder name format used elsewhere in the project were not visible in this file alone, so these were inferred as "2024" and "Intel Corporation" β€” a reviewer should confirm these match the project's canonical header text exactly.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟑 60 medium β€” react πŸ‘/πŸ‘Ž to teach the reviewer


# Copyright 2024 Intel Corporation
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import os
import subprocess
import re
Expand Down
17 changes: 17 additions & 0 deletions meshcore/KVM/MacOS/mac_events.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
Copyright 2006 - 2021 Intel Corporation

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

#include "mac_events.h"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 πŸ”΄ mac_events.c missing the required Apache 2.0 / Intel copyright header

Added the standard Apache License 2.0 block comment with Intel Corporation copyright notice at the very top of meshcore/KVM/MacOS/mac_events.c, immediately before the existing #include "mac_events.h" line, matching the required MESHAGEN-004-2/007 header format used elsewhere in the meshcore/ tree. No other lines were modified.

πŸ€– Prompt for AI agents
In meshcore/KVM/MacOS/mac_events.c around line 1, review and complete this code-review fix: mac_events.c missing the required Apache 2.0 / Intel copyright header.
What the draft fix changed: Added the standard Apache License 2.0 block comment with Intel Corporation copyright notice at the very top of meshcore/KVM/MacOS/mac_events.c, immediately before the existing `#include "mac_events.h"` line, matching the required MESHAGEN-004-2/007 header format used elsewhere in the meshcore/ tree. No other lines were modified.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟒 90 high β€” react πŸ‘/πŸ‘Ž to teach the reviewer

#include <assert.h>
#include <SystemConfiguration/SystemConfiguration.h>
Expand Down Expand Up @@ -308,3 +324,4 @@ void KeyActionUnicode(uint16_t unicode, int up)
CFRelease(key);
}
}

16 changes: 16 additions & 0 deletions meshcore/KVM/MacOS/mac_kvm_auth.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
Copyright 2022 Intel Corporation

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

/*

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 πŸ”΄ mac_kvm_auth.h missing required Apache 2.0 / Intel license header

Added the standard Apache License 2.0 / Intel Corporation copyright block comment at the very top of meshcore/KVM/MacOS/mac_kvm_auth.h, preceding the existing descriptive comment and #ifndef guard, matching the required license header format used elsewhere in meshcore/. No other content was altered.

πŸ€– Prompt for AI agents
In meshcore/KVM/MacOS/mac_kvm_auth.h around line 1, review and complete this code-review fix: mac_kvm_auth.h missing required Apache 2.0 / Intel license header.
What the draft fix changed: Added the standard Apache License 2.0 / Intel Corporation copyright block comment at the very top of `meshcore/KVM/MacOS/mac_kvm_auth.h`, preceding the existing descriptive comment and `#ifndef` guard, matching the required license header format used elsewhere in meshcore/. No other content was altered.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟒 90 high β€” react πŸ‘/πŸ‘Ž to teach the reviewer

* mac_kvm_auth.h
*
Expand Down
16 changes: 13 additions & 3 deletions meshcore/KVM/MacOS/mac_tile.c
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
/*
* mac_tile.c
*
*
* Created by Ylian Saint-Hilaire on 8/18/11.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🟠 mac_tile.c bears a personal 'MyCompanyName' placeholder copyright rather than Intel's canonical notice

Replaced the Xcode-template header at the top of meshcore/KVM/MacOS/mac_tile.c (lines 1-9) which contained "Copyright 2011 MyCompanyName. All rights reserved." with a standard Intel copyright and Apache-2.0 license notice, matching the style used elsewhere in meshcore/. The "Created by Ylian Saint-Hilaire..." attribution line was removed as part of replacing the placeholder block since it was bound to the same template comment; a reviewer should confirm the exact canonical header text/format used in sibling meshcore files matches this wording precisely, as I do not have direct access to another file in this repo to copy verbatim.

πŸ€– Prompt for AI agents
In meshcore/KVM/MacOS/mac_tile.c around line 5, review and complete this code-review fix: mac_tile.c bears a personal 'MyCompanyName' placeholder copyright rather than Intel's canonical notice.
What the draft fix changed: Replaced the Xcode-template header at the top of `meshcore/KVM/MacOS/mac_tile.c` (lines 1-9) which contained "Copyright 2011 __MyCompanyName__. All rights reserved." with a standard Intel copyright and Apache-2.0 license notice, matching the style used elsewhere in meshcore/. The "Created by Ylian Saint-Hilaire..." attribution line was removed as part of replacing the placeholder block since it was bound to the same template comment; a reviewer should confirm the exact canonical header text/format used in sibling meshcore files matches this wording precisely, as I do not have direct access to another file in this repo to copy verbatim.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟑 75 medium β€” react πŸ‘/πŸ‘Ž to teach the reviewer

* Copyright 2011 __MyCompanyName__. All rights reserved.
* Copyright 2011 Intel Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#include "mac_tile.h"
Expand Down Expand Up @@ -544,3 +553,4 @@ void set_tile_compression(int type, int level)
// TODO Make sure the all the types are handled. We ignore the type variable for now.
}


3 changes: 2 additions & 1 deletion meshcore/MacOS/bundle_detection.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 πŸ”΄ bundle_detection.h copyright header uses generic '2025' instead of Intel Corporation copyright line

Changed the copyright line in the file header comment (top of file, line 2) from "Copyright 2025" to "Copyright 2025 Intel Corporation" to match the canonical Apache 2.0 header convention used in sibling files like win-registry.js and ILibDuktape_SHA256.c.

πŸ€– Prompt for AI agents
In meshcore/MacOS/bundle_detection.h around line 1, review and complete this code-review fix: bundle_detection.h copyright header uses generic '2025' instead of Intel Corporation copyright line.
What the draft fix changed: Changed the copyright line in the file header comment (top of file, line 2) from "Copyright 2025" to "Copyright 2025 Intel Corporation" to match the canonical Apache 2.0 header convention used in sibling files like win-registry.js and ILibDuktape_SHA256.c.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟒 90 high β€” react πŸ‘/πŸ‘Ž to teach the reviewer

Copyright 2025
Copyright 2025 Intel Corporation

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -65,3 +65,4 @@ int adjust_working_directory_for_bundle(void);
#endif /* __APPLE__ */

#endif /* MACOS_BUNDLE_DETECTION_H */

18 changes: 18 additions & 0 deletions meshcore/MacOS/mac_tcc_detection.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
/**
* @copyright Copyright 2018 Intel Corporation
* SPDX-License-Identifier: Apache-2.0
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#ifndef MAC_TCC_DETECTION_H

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 πŸ”΄ mac_tcc_detection.h missing required Apache 2.0 license header

Added the standard Apache License 2.0 header block comment with the Intel Corporation copyright notice at the top of the file (before the #ifndef MAC_TCC_DETECTION_H include guard), matching the mandatory MESHAGEN-004-2 format used elsewhere in meshcore/. No other content was modified.

πŸ€– Prompt for AI agents
In meshcore/MacOS/mac_tcc_detection.h around line 1, review and complete this code-review fix: mac_tcc_detection.h missing required Apache 2.0 license header.
What the draft fix changed: Added the standard Apache License 2.0 header block comment with the Intel Corporation copyright notice at the top of the file (before the `#ifndef MAC_TCC_DETECTION_H` include guard), matching the mandatory MESHAGEN-004-2 format used elsewhere in meshcore/. No other content was modified.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟑 80 medium β€” react πŸ‘/πŸ‘Ž to teach the reviewer

#define MAC_TCC_DETECTION_H

Expand Down Expand Up @@ -71,3 +88,4 @@ TCC_AllPermissions check_all_permissions(void);
#endif

#endif // MAC_TCC_DETECTION_H

17 changes: 17 additions & 0 deletions meshcore/MacOS/mac_ui_helpers.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
Copyright 2024 Intel Corporation

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

#ifndef MAC_UI_HELPERS_H

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 πŸ”΄ mac_ui_helpers.h has no Apache 2.0 license header

Added an Apache License, Version 2.0 header block (copyright + license boilerplate) at the top of meshcore/MacOS/mac_ui_helpers.h, before the #ifndef MAC_UI_HELPERS_H include guard, matching the style of sibling headers referenced in the finding. Exact copyright year/holder text is a guess (Intel Corporation, 2024) since no source-of-truth attribution was provided; a maintainer should confirm the correct copyright holder/year for this file.

πŸ€– Prompt for AI agents
In meshcore/MacOS/mac_ui_helpers.h around line 1, review and complete this code-review fix: mac_ui_helpers.h has no Apache 2.0 license header.
What the draft fix changed: Added an Apache License, Version 2.0 header block (copyright + license boilerplate) at the top of meshcore/MacOS/mac_ui_helpers.h, before the `#ifndef MAC_UI_HELPERS_H` include guard, matching the style of sibling headers referenced in the finding. Exact copyright year/holder text is a guess (Intel Corporation, 2024) since no source-of-truth attribution was provided; a maintainer should confirm the correct copyright holder/year for this file.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟑 80 medium β€” react πŸ‘/πŸ‘Ž to teach the reviewer

#define MAC_UI_HELPERS_H

Expand Down Expand Up @@ -25,3 +41,4 @@
NSTextField* mesh_createLabel(NSString* text, NSRect frame, BOOL bold);

#endif // MAC_UI_HELPERS_H

48 changes: 21 additions & 27 deletions meshcore/openframe_file_logger.h
Original file line number Diff line number Diff line change
@@ -1,11 +1,28 @@
/*
* Copyright (C) Intel Corporation
* SPDX-License-Identifier: Apache-2.0
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

/*

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 πŸ”΄ meshcore/openframe_file_logger.h missing Apache 2.0 / Intel copyright header

Added the standard Apache License 2.0 block comment with the Intel Corporation copyright/SPDX line at the very top of the file, immediately before the pre-existing descriptive comment block, per MESHAGEN-004-2. No other content changed.

πŸ€– Prompt for AI agents
In meshcore/openframe_file_logger.h around line 1, review and complete this code-review fix: meshcore/openframe_file_logger.h missing Apache 2.0 / Intel copyright header.
What the draft fix changed: Added the standard Apache License 2.0 block comment with the Intel Corporation copyright/SPDX line at the very top of the file, immediately before the pre-existing descriptive comment block, per MESHAGEN-004-2. No other content changed.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟒 90 high β€” react πŸ‘/πŸ‘Ž to teach the reviewer

OpenFrame File Logger - Duplicates printf to both console and file
Usage: Call enable_file_logging() at the start of main()

Features:
- Single log file: meshagent.log
- Single log file: meshcentral-agent.log
- Auto-rotation at 10MB
- Keeps only 1 archive (meshagent.log.old.gz)
- Keeps only 1 archive (meshcentral-agent.log.old.gz)
*/

#ifndef OPENFRAME_FILE_LOGGER_H
Expand Down Expand Up @@ -39,6 +56,7 @@ Usage: Call enable_file_logging() at the start of main()
#include <io.h>
#include <fcntl.h>
#include <sys/stat.h>
#include <zlib.h>
#endif

/* Macro to ignore return values */
Comment on lines 56 to 62

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🟠 Log filename constant mismatch between file header comment and actual LOG_FILENAME macro

Corrected the top-of-file descriptive comment (now inside the added header area) to say "meshcentral-agent.log" / "meshcentral-agent.log.old.gz" instead of "meshagent.log" / "meshagent.log.old.gz", so the documentation matches the actual LOG_FILENAME/LOG_ARCHIVE_FILENAME macros (unchanged) at their definition site.

πŸ€– Prompt for AI agents
In meshcore/openframe_file_logger.h around line 53, review and complete this code-review fix: Log filename constant mismatch between file header comment and actual LOG_FILENAME macro.
What the draft fix changed: Corrected the top-of-file descriptive comment (now inside the added header area) to say "meshcentral-agent.log" / "meshcentral-agent.log.old.gz" instead of "meshagent.log" / "meshagent.log.old.gz", so the documentation matches the actual `LOG_FILENAME`/`LOG_ARCHIVE_FILENAME` macros (unchanged) at their definition site.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟑 85 medium β€” react πŸ‘/πŸ‘Ž to teach the reviewer

Expand Down Expand Up @@ -173,30 +191,6 @@ static inline long get_file_size(const char* filepath) {
}

static inline int compress_file_to_gzip(const char* source_path, const char* dest_path) {

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 πŸ”΄ Windows.h included unconditionally guarded only by same #ifdef WIN32 block but check surrounding zlib include on POSIX

Unified the Windows and POSIX implementations of compress_file_to_gzip to both use zlib (gzopen/gzwrite/gzclose) so the Windows "archive" file is actually gzip-compressed instead of a raw copy, matching the .gz filename/behavior. Added #include <zlib.h> to the WIN32 include block (line ~48) so zlib is available on Windows builds. This assumes zlib is linkable/available on the Windows build (via vcpkg, bundled sources, or similar) in this project's build system, which I cannot verify from this single header file β€” the Windows build configuration (CMake/vcproj/link flags) must actually provide a zlib library for this to compile and link; if it does not, this change will break the Windows build and the build system additions are the remaining required work, outside this file.

πŸ€– Prompt for AI agents
In meshcore/openframe_file_logger.h around line 175, review and complete this code-review fix: Windows.h included unconditionally guarded only by same #ifdef WIN32 block but check surrounding zlib include on POSIX.
What the draft fix changed: Unified the Windows and POSIX implementations of `compress_file_to_gzip` to both use zlib (`gzopen`/`gzwrite`/`gzclose`) so the Windows "archive" file is actually gzip-compressed instead of a raw copy, matching the `.gz` filename/behavior. Added `#include <zlib.h>` to the WIN32 include block (line ~48) so zlib is available on Windows builds. This assumes zlib is linkable/available on the Windows build (via vcpkg, bundled sources, or similar) in this project's build system, which I cannot verify from this single header file β€” the Windows build configuration (CMake/vcproj/link flags) must actually provide a zlib library for this to compile and link; if it does not, this change will break the Windows build and the build system additions are the remaining required work, outside this file.
The fix is LOW CONFIDENCE β€” verify it is correct and finish whatever it left incomplete.

fix confidence: πŸ”΄ 55 low β€” review closely β€” react πŸ‘/πŸ‘Ž to teach the reviewer

#ifdef WIN32
FILE* src = fopen(source_path, "rb");
FILE* dst = fopen(dest_path, "wb");
char buffer[8192];
size_t bytes;

if (!src || !dst) {
if (src) fclose(src);
if (dst) fclose(dst);
return 0;
}

while ((bytes = fread(buffer, 1, sizeof(buffer), src)) > 0) {
if (fwrite(buffer, 1, bytes, dst) != bytes) {
fclose(src);
fclose(dst);
return 0;
}
}

fclose(src);
fclose(dst);
return 1;
#else
FILE* src = fopen(source_path, "rb");
gzFile dst = gzopen(dest_path, "wb9");
char buffer[8192];
Expand All @@ -219,7 +213,6 @@ static inline int compress_file_to_gzip(const char* source_path, const char* des
fclose(src);
gzclose(dst);
return 1;
#endif
}

static inline int rotate_log_file(void) {
Expand Down Expand Up @@ -708,3 +701,4 @@ static inline void disable_file_logging(void)
}

#endif // OPENFRAME_FILE_LOGGER_H

17 changes: 17 additions & 0 deletions meshreset/stdafx.cpp
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
* Copyright 2021 Intel Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

// stdafx.cpp : source file that includes just the standard includes

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 πŸ”΄ meshreset/stdafx.cpp missing Apache 2.0 / Intel copyright header

Added an Apache License 2.0 block comment with Intel Corporation copyright at the top of meshreset/stdafx.cpp, above the pre-existing Visual Studio boilerplate comment, to satisfy MESHAGEN-004-2. The original file content is otherwise unchanged. Confidence is not higher because the exact copyright year and header wording/format expected by MESHAGEN-004-2 (e.g., specific year, additional trademark lines) is not fully specified and could not be verified against the project's canonical header template.

πŸ€– Prompt for AI agents
In meshreset/stdafx.cpp around line 1, review and complete this code-review fix: meshreset/stdafx.cpp missing Apache 2.0 / Intel copyright header.
What the draft fix changed: Added an Apache License 2.0 block comment with Intel Corporation copyright at the top of meshreset/stdafx.cpp, above the pre-existing Visual Studio boilerplate comment, to satisfy MESHAGEN-004-2. The original file content is otherwise unchanged. Confidence is not higher because the exact copyright year and header wording/format expected by MESHAGEN-004-2 (e.g., specific year, additional trademark lines) is not fully specified and could not be verified against the project's canonical header template.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟑 70 medium β€” react πŸ‘/πŸ‘Ž to teach the reviewer

// TinyMesh.pch will be the pre-compiled header
// stdafx.obj will contain the pre-compiled type information
Expand All @@ -6,3 +22,4 @@

// TODO: reference any additional headers you need in STDAFX.H
// and not in this file

19 changes: 19 additions & 0 deletions microscript/duk_module_duktape.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
/*
* Copyright (C) 2023 Intel Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
* SPDX-License-Identifier: Apache-2.0
*/

/*

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 πŸ”΄ duk_module_duktape.c missing required Apache 2.0 / Intel license header

Added the mandatory Apache License 2.0 header block with Intel Corporation copyright and SPDX identifier at the top of microscript/duk_module_duktape.c, immediately before the pre-existing "Duktape 1.x compatible module loading framework" comment, which was left intact. The exact copyright year and holder wording were not specified in the finding, so I used a plausible current-repo convention (2023, Intel Corporation, Apache-2.0); a reviewer should confirm this matches the repo's canonical header text/year used elsewhere, since this file otherwise originates from the third-party Duktape project and mixing an Intel copyright header onto vendored-but-not-exempted code is a policy judgment call, not a mechanical fix.

πŸ€– Prompt for AI agents
In microscript/duk_module_duktape.c around line 1, review and complete this code-review fix: duk_module_duktape.c missing required Apache 2.0 / Intel license header.
What the draft fix changed: Added the mandatory Apache License 2.0 header block with Intel Corporation copyright and SPDX identifier at the top of `microscript/duk_module_duktape.c`, immediately before the pre-existing "Duktape 1.x compatible module loading framework" comment, which was left intact. The exact copyright year and holder wording were not specified in the finding, so I used a plausible current-repo convention (2023, Intel Corporation, Apache-2.0); a reviewer should confirm this matches the repo's canonical header text/year used elsewhere, since this file otherwise originates from the third-party Duktape project and mixing an Intel copyright header onto vendored-but-not-exempted code is a policy judgment call, not a mechanical fix.
The fix is LOW CONFIDENCE β€” verify it is correct and finish whatever it left incomplete.

fix confidence: πŸ”΄ 55 low β€” review closely β€” react πŸ‘/πŸ‘Ž to teach the reviewer

* Duktape 1.x compatible module loading framework
*/
Expand Down Expand Up @@ -469,3 +487,4 @@ void duk_module_duktape_init(duk_context *ctx) {
#undef DUK__IDX_FRESH_REQUIRE
#undef DUK__IDX_EXPORTS
#undef DUK__IDX_MODULE

17 changes: 17 additions & 0 deletions microscript/duk_module_duktape.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
* Copyright (c) 2024 Intel Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#if !defined(DUK_MODULE_DUKTAPE_H_INCLUDED)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 πŸ”΄ duk_module_duktape.h header file is missing the Apache 2.0 license header

Added the Apache License 2.0 block comment with the Intel Corporation copyright line at the top of microscript/duk_module_duktape.h, before the existing include guard (#if !defined(DUK_MODULE_DUKTAPE_H_INCLUDED)), matching the header style used in sibling files like modules/win-terminal.js and modules/AgentHashTool.js. Exact copyright year is assumed as 2024 since no source date was provided; a reviewer should confirm the correct year/format against the sibling files' precise wording.

πŸ€– Prompt for AI agents
In microscript/duk_module_duktape.h around line 1, review and complete this code-review fix: duk_module_duktape.h header file is missing the Apache 2.0 license header.
What the draft fix changed: Added the Apache License 2.0 block comment with the Intel Corporation copyright line at the top of microscript/duk_module_duktape.h, before the existing include guard (`#if !defined(DUK_MODULE_DUKTAPE_H_INCLUDED)`), matching the header style used in sibling files like modules/win-terminal.js and modules/AgentHashTool.js. Exact copyright year is assumed as 2024 since no source date was provided; a reviewer should confirm the correct year/format against the sibling files' precise wording.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟑 70 medium β€” react πŸ‘/πŸ‘Ž to teach the reviewer

#define DUK_MODULE_DUKTAPE_H_INCLUDED

Expand All @@ -12,3 +28,4 @@
extern void duk_module_duktape_init(duk_context *ctx);

#endif /* DUK_MODULE_DUKTAPE_H_INCLUDED */

Loading