fix(MESHAGEN-003-2): CU-86akhf8u3 mac_kvm_auth.c public functions lack MeshAgent_/MeshCommand_ prefix required for meshcore/ symbols

[flamingo]

Closes findings from rule MESHAGEN-003-2 — mac_kvm_auth.c public functions lack MeshAgent_/MeshCommand_ prefix required for meshcore/ symbols.

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

#	Fix confidence	Finding	Location
1	🔴 55 low — review closely	mac_kvm_auth.c public functions lack MeshAgent_/MeshCommand_ prefix required for meshcore/ symbols	meshcore/KVM/MacOS/mac_kvm_auth.c:18

What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.

---

Run: https://product-hub.flamingo.so/admin/code-review
Run id: bc788a01-3d0c-4679-816f-282037bb5004

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

ClickUp task: CU-86akhf8u3 MeshAgent review findings sweep (13 PRs)

[flamingo]

🦩 What this fix changed, finding by finding

1 finding(s) fixed in this draft — 1 explained inline on the diff; 1 low-confidence hunk(s) need close review before merging.

[flamingo]

🦩 🔴 mac_kvm_auth.c public functions lack MeshAgent_/MeshCommand_ prefix required for meshcore/ symbols

Renamed the three public functions in meshcore/KVM/MacOS/mac_kvm_auth.c to carry the mandated prefix: get_self_code -> MeshAgent_KVM_GetSelfCode, codesign_matches -> MeshAgent_KVM_CodesignMatches, verify_peer_codesign -> MeshAgent_KVM_VerifyPeerCodesign. All internal call sites within this file (the self-code call inside MeshAgent_KVM_VerifyPeerCodesign and the codesign comparison call) were updated to use the new names. Risk: the corresponding header mac_kvm_auth.h (not shown/not in scope) and any other translation units calling these functions by their old names must also be updated to match, or the build will fail to link; that header/caller update is outside this single-file fix and is not verified here.

🤖 Prompt for AI agents

In meshcore/KVM/MacOS/mac_kvm_auth.c around line 18, review and complete this code-review fix: mac_kvm_auth.c public functions lack MeshAgent_/MeshCommand_ prefix required for meshcore/ symbols.
What the draft fix changed: Renamed the three public functions in meshcore/KVM/MacOS/mac_kvm_auth.c to carry the mandated prefix: `get_self_code` -> `MeshAgent_KVM_GetSelfCode`, `codesign_matches` -> `MeshAgent_KVM_CodesignMatches`, `verify_peer_codesign` -> `MeshAgent_KVM_VerifyPeerCodesign`. All internal call sites within this file (the self-code call inside `MeshAgent_KVM_VerifyPeerCodesign` and the codesign comparison call) were updated to use the new names. Risk: the corresponding header `mac_kvm_auth.h` (not shown/not in scope) and any other translation units calling these functions by their old names must also be updated to match, or the build will fail to link; that header/caller update is outside this single-file fix and is not verified here.
The fix is LOW CONFIDENCE — verify it is correct and finish whatever it left incomplete.

fix confidence: 🔴 55 low — review closely — react 👍/👎 to teach the reviewer