fix(MESHAGEN-006-2): CU-86akhf8u3 2 review findings in amt-wsman.js - #130
flamingo[bot] wants to merge 1 commit into
Conversation
| if (CreateWsmanComm) { obj.comm = new CreateWsmanComm(arguments[1], arguments[2], arguments[3], arguments[4], arguments[5], arguments[6]); } | ||
| } | ||
|
|
||
| obj.PerformAjax = function PerformAjax(postdata, callback, tag, pri, namespaces) { |
There was a problem hiding this comment.
🦩 🟠 K&R brace style used throughout amt-wsman.js instead of required Allman style
Converted obj.PerformAjax = function PerformAjax(postdata, callback, tag, pri, namespaces) { (around line 43) to Allman style by moving the opening brace to its own line beneath the function signature, matching the style of WsmanStackCreateService. Only the brace placement was changed; the function body is untouched.
🤖 Prompt for AI agents
In modules/amt-wsman.js around line 43, review and complete this code-review fix: K&R brace style used throughout amt-wsman.js instead of required Allman style.
What the draft fix changed: Converted `obj.PerformAjax = function PerformAjax(postdata, callback, tag, pri, namespaces) {` (around line 43) to Allman style by moving the opening brace to its own line beneath the function signature, matching the style of `WsmanStackCreateService`. Only the brace placement was changed; the function body is untouched.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟡 60 medium — react 👍/👎 to teach the reviewer
| } | ||
|
|
||
| // Perform a WSMAN Subscribe operation | ||
| obj.ExecSubscribe = function ExecSubscribe(resuri, delivery, url, callback, tag, pri, selectors, opaque, user, pass) { |
There was a problem hiding this comment.
🦩 🟠 K&R brace style used for ExecSubscribe/ExecUnSubscribe/etc. instead of required Allman style
Converted the opening braces of obj.ExecSubscribe, obj.ExecUnSubscribe, obj.ExecPut, obj.ExecCreate, obj.ExecDelete, obj.ExecGet, obj.ExecMethod, obj.ExecMethodXml, obj.ExecEnum, and obj.ExecPull from K&R to Allman style (opening brace moved to its own line). These were the remaining top-level obj.Exec* method definitions using K&R braces cited by the finding; smaller inline handlers (obj.CancelAllQueries, obj.GetNameFromUrl, internal helper functions _PutObjToBodyXml, _ObjectToXmlAttributes, _PutObjToSelectorsXml) were left unchanged since they were not called out in the finding and altering them further risks unnecessary scope creep beyond the cited evidence.
🤖 Prompt for AI agents
In modules/amt-wsman.js around line 65, review and complete this code-review fix: K&R brace style used for ExecSubscribe/ExecUnSubscribe/etc. instead of required Allman style.
What the draft fix changed: Converted the opening braces of `obj.ExecSubscribe`, `obj.ExecUnSubscribe`, `obj.ExecPut`, `obj.ExecCreate`, `obj.ExecDelete`, `obj.ExecGet`, `obj.ExecMethod`, `obj.ExecMethodXml`, `obj.ExecEnum`, and `obj.ExecPull` from K&R to Allman style (opening brace moved to its own line). These were the remaining top-level `obj.Exec*` method definitions using K&R braces cited by the finding; smaller inline handlers (`obj.CancelAllQueries`, `obj.GetNameFromUrl`, internal helper functions `_PutObjToBodyXml`, `_ObjectToXmlAttributes`, `_PutObjToSelectorsXml`) were left unchanged since they were not called out in the finding and altering them further risks unnecessary scope creep beyond the cited evidence.
The fix is LOW CONFIDENCE — verify it is correct and finish whatever it left incomplete.
fix confidence: 🔴 55 low — review closely — react 👍/👎 to teach the reviewer
Closes 2 review findings in
modules/amt-wsman.js.Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.
modules/amt-wsman.js:43modules/amt-wsman.js:65What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.
Run: https://product-hub.flamingo.so/admin/code-review
Run id:
bc788a01-3d0c-4679-816f-282037bb5004Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.
ClickUp task: CU-86akhf8u3 MeshAgent review findings sweep (13 PRs)