fix(MESHAGEN-009): CU-86akhf8u3 require('promise') hoisted as local var reused across branches without inline pattern violation but note stray global leak - #132
Draft
flamingo[bot] wants to merge 1 commit into
Conversation
…oss branches without inline pattern violation but note stray global leak
| @@ -179,7 +179,7 @@ function powerMonitor() | |||
| this.sleepDisplay = function sleepDispay(force) | |||
| { | |||
| var promise = require('promise'); | |||
Author
There was a problem hiding this comment.
🦩 🟠 require('promise') hoisted as local var reused across branches without inline pattern violation but note stray global leak
In sleepDisplay and wakeDisplay (both defined as this.sleepDisplay = function sleepDispay(force) {...} and this.wakeDisplay = function wakeDisplay() {...} in powerMonitor), the assignment p = new promise(...) was changed to var p = new promise(...) in both functions, declaring p as a local variable instead of leaking it to the global object in non-strict mode.
🤖 Prompt for AI agents
In modules/power-monitor.js around line 181, review and complete this code-review fix: require('promise') hoisted as local var reused across branches without inline pattern violation but note stray global leak.
What the draft fix changed: In `sleepDisplay` and `wakeDisplay` (both defined as `this.sleepDisplay = function sleepDispay(force) {...}` and `this.wakeDisplay = function wakeDisplay() {...}` in `powerMonitor`), the assignment `p = new promise(...)` was changed to `var p = new promise(...)` in both functions, declaring `p` as a local variable instead of leaking it to the global object in non-strict mode.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟢 95 high — react 👍/👎 to teach the reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes findings from rule MESHAGEN-009 — require('promise') hoisted as local var reused across branches without inline pattern violation but note stray global leak.
Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.
modules/power-monitor.js:181What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.
Run: https://product-hub.flamingo.so/admin/code-review
Run id:
bc788a01-3d0c-4679-816f-282037bb5004Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.
ClickUp task: CU-86akhf8u3 MeshAgent review findings sweep (13 PRs)