fix(MESHAGEN-002): CU-86akhf8u3 Non-ILibDuktape_-prefixed helper functions in a microscript binding file - #134
flamingo[bot] wants to merge 1 commit into
Conversation
…croscript binding file
|
|
||
| int ILibDuktape_ModSearch_ShowNames = 0; | ||
|
|
||
| duk_ret_t ModSearchTable_Get(duk_context *ctx, duk_idx_t table, char *key, char *id) |
There was a problem hiding this comment.
🦩 🟠 Non-ILibDuktape_-prefixed helper functions in a microscript binding file
Renamed the four file-local helper functions to carry the ILibDuktape_ prefix per MESHAGEN-002: ModSearchTable_Get -> ILibDuktape_ModSearchTable_Get, ModSearchTable_Put -> ILibDuktape_ModSearchTable_Put, mod_Search -> ILibDuktape_ModSearch_Search, mod_Search_Files -> ILibDuktape_ModSearch_Search_Files. Updated every call site within this file (in ILibDuktape_ModSearch_GetJSModuleDate, ILibDuktape_ModSearch_IsRequired, ILibDuktape_ModSearch_GetJSModule, ILibDuktape_ModSearch_AddModuleObject, ILibDuktape_ModSearch_AddModuleEx, ILibDuktape_ModSearch_AddHandler, and ILibDuktape_ModSearch_Init where mod_Search is registered via duk_push_c_function) to use the new names. These functions were not declared in the header (only visible in this .c file), so no other files reference the old names; risk is limited to unseen forward declarations elsewhere in the repo, which I could not inspect.
🤖 Prompt for AI agents
In microscript/ILibDuktapeModSearch.c around line 44, review and complete this code-review fix: Non-ILibDuktape_-prefixed helper functions in a microscript binding file.
What the draft fix changed: Renamed the four file-local helper functions to carry the ILibDuktape_ prefix per MESHAGEN-002: `ModSearchTable_Get` -> `ILibDuktape_ModSearchTable_Get`, `ModSearchTable_Put` -> `ILibDuktape_ModSearchTable_Put`, `mod_Search` -> `ILibDuktape_ModSearch_Search`, `mod_Search_Files` -> `ILibDuktape_ModSearch_Search_Files`. Updated every call site within this file (in `ILibDuktape_ModSearch_GetJSModuleDate`, `ILibDuktape_ModSearch_IsRequired`, `ILibDuktape_ModSearch_GetJSModule`, `ILibDuktape_ModSearch_AddModuleObject`, `ILibDuktape_ModSearch_AddModuleEx`, `ILibDuktape_ModSearch_AddHandler`, and `ILibDuktape_ModSearch_Init` where `mod_Search` is registered via `duk_push_c_function`) to use the new names. These functions were not declared in the header (only visible in this .c file), so no other files reference the old names; risk is limited to unseen forward declarations elsewhere in the repo, which I could not inspect.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟡 85 medium — react 👍/👎 to teach the reviewer
Closes findings from rule MESHAGEN-002 — Non-ILibDuktape_-prefixed helper functions in a microscript binding file.
Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.
microscript/ILibDuktapeModSearch.c:44What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.
Run: https://product-hub.flamingo.so/admin/code-review
Run id:
bc788a01-3d0c-4679-816f-282037bb5004Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.
ClickUp task: CU-86akhf8u3 MeshAgent review findings sweep (13 PRs)