Skip to content

fix(OSQUERY-001): CU-86akbhhc0 2 review findings in machine_id_reader.c #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flamingo wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −0
Draft

fix(OSQUERY-001): CU-86akbhhc0 2 review findings in machine_id_reader.c #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions openframe/machine_id_reader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
* Copyright (c) 2024 Intel Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#include <stdio.h>

@flamingo flamingo Bot Aug 24, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🔴 openframe/machine_id_reader.c missing required copyright/SPDX header

Added a standard Apache License 2.0 header block with Intel Corporation copyright at the top of openframe/machine_id_reader.c, before the #include statements, addressing the missing copyright/SPDX header. Did not add osquery-style namespace or Status-based error handling changes since those would be a larger refactor beyond the scope of a minimal header fix; a complete OSQUERY-010 compliance fix would additionally require converting the C API to C++ with Status returns, which is architectural and out of scope here.

🤖 Prompt for AI agents 
In openframe/machine_id_reader.c around line 1, review and complete this code-review fix: openframe/machine_id_reader.c missing required copyright/SPDX header.
What the draft fix changed: Added a standard Apache License 2.0 header block with Intel Corporation copyright at the top of openframe/machine_id_reader.c, before the #include statements, addressing the missing copyright/SPDX header. Did not add osquery-style namespace or Status-based error handling changes since those would be a larger refactor beyond the scope of a minimal header fix; a complete OSQUERY-010 compliance fix would additionally require converting the C API to C++ with Status returns, which is architectural and out of scope here.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟡 65 medium — react 👍/👎 to teach the reviewer

@flamingo flamingo Bot Aug 24, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🔴 openframe/machine_id_reader.c lacks the required Apache 2.0/Intel license header

Same header block addition satisfies MESHAGEN-004-2's requirement for an Apache 2.0/Intel license header on first-party C sources; text matches the convention style implied by other repo files (e.g., firewall.cpp).

🤖 Prompt for AI agents 
In openframe/machine_id_reader.c around line 1, review and complete this code-review fix: openframe/machine_id_reader.c lacks the required Apache 2.0/Intel license header.
What the draft fix changed: Same header block addition satisfies MESHAGEN-004-2's requirement for an Apache 2.0/Intel license header on first-party C sources; text matches the convention style implied by other repo files (e.g., firewall.cpp).
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟡 70 medium — react 👍/👎 to teach the reviewer

#include <stdlib.h>
#include <string.h>
Expand Down Expand Up @@ -95,3 +111,4 @@ char* read_machine_id() {
}

#endif