Skip to content

fix(MESHAGEN-006): CU-86akbhhdk WinSock headers included unconditionally in WebRTC.cpp #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flamingo wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Draft

fix(MESHAGEN-006): CU-86akbhhdk WinSock headers included unconditionally in WebRTC.cpp #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion samples/webrtc/C# Sample/WebRTC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ limitations under the License.
#include "stdafx.h"

@flamingo flamingo Bot Aug 24, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🔴 WinSock headers included unconditionally in WebRTC.cpp

Wrapped the #include <WinSock2.h> and #include <WS2tcpip.h> lines near the top of the file (previously unconditional at file scope) in #ifdef WIN32 / #endif, matching the suggested fix exactly. This prevents these Windows-only headers from being pulled in on POSIX builds of this translation unit, while leaving all other content (including the separate #if defined(WIN32) block for _CRTDBG_MAP_ALLOC) untouched.

🤖 Prompt for AI agents 
In samples/webrtc/C# Sample/WebRTC.cpp around line 21, review and complete this code-review fix: WinSock headers included unconditionally in WebRTC.cpp.
What the draft fix changed: Wrapped the `#include <WinSock2.h>` and `#include <WS2tcpip.h>` lines near the top of the file (previously unconditional at file scope) in `#ifdef WIN32` / `#endif`, matching the suggested fix exactly. This prevents these Windows-only headers from being pulled in on POSIX builds of this translation unit, while leaving all other content (including the separate `#if defined(WIN32)` block for `_CRTDBG_MAP_ALLOC`) untouched.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 90 high — react 👍/👎 to teach the reviewer

#include "WebRTC.h"

#ifdef WIN32
#include <WinSock2.h>
#include <WS2tcpip.h>
#endif

#if defined(WIN32)
#define _CRTDBG_MAP_ALLOC
Expand Down Expand Up @@ -469,4 +471,4 @@ extern "C"
return(ILibSCTP_Debug_SetDebugCallback(((void**)connection)[0], debugField, handler));
}
#endif
}
}