Skip to content

fix(MESHCENT-003): CU-86akbhhdk meshinstall-initd.sh PID file removal uses malformed quoting, likely deletes wrong file (missing path traversal protection also unclear) #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flamingo wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Draft

fix(MESHCENT-003): CU-86akbhhdk meshinstall-initd.sh PID file removal uses malformed quoting, likely deletes wrong file (missing path traversal protection also unclear) #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion agents/meshinstall-initd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ stop() {
else
echo 'Service not running'
fi
rm -f $"PIDFILE"

@flamingo flamingo Bot Sep 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🔴 meshinstall-initd.sh PID file removal uses malformed quoting, likely deletes wrong file (missing path traversal protection also unclear)

Changed rm -f $"PIDFILE" to rm -f "$PIDFILE" in the stop() function, fixing the malformed quoting so the actual PID file path stored in the $PIDFILE variable is removed instead of the literal string "PIDFILE".

🤖 Prompt for AI agents 
In agents/meshinstall-initd.sh around line 43, review and complete this code-review fix: meshinstall-initd.sh PID file removal uses malformed quoting, likely deletes wrong file (missing path traversal protection also unclear).
What the draft fix changed: Changed `rm -f $"PIDFILE"` to `rm -f "$PIDFILE"` in the `stop()` function, fixing the malformed quoting so the actual PID file path stored in the `$PIDFILE` variable is removed instead of the literal string "PIDFILE".
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 95 high — react 👍/👎 to teach the reviewer

rm -f "$PIDFILE"
fi
}
restart(){
Expand Down Expand Up @@ -82,3 +82,4 @@ case "$1" in
;;
esac
exit 0