Skip to content

fix(NATSRS-001-2): CU-86akbh48z service/mod.rs Service::add returns Box<dyn Error> style ad-hoc io::Error instead of a typed *ErrorKind - #111

Draft
flamingo[bot] wants to merge 1 commit into
mainfrom
ai-fix/natsrs-001-2-4eebef8e-06b1d724
Draft

flamingo[bot] wants to merge 1 commit into
mainfrom
ai-fix/natsrs-001-2-4eebef8e-06b1d724

Conversation

@flamingo

@flamingo flamingo Bot commented Sep 7, 2026

Copy link
Copy Markdown

Closes findings from rule NATSRS-001-2 — service/mod.rs Service::add returns Box style ad-hoc io::Error instead of a typed *ErrorKind.

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

# Finding Location
1 🔴 service/mod.rs Service::add returns Box style ad-hoc io::Error instead of a typed *ErrorKind async-nats/src/service/mod.rs:330
2 🟠 service task loop uses unwrap() on ping.reply / info_request.reply / stats_request.reply, panicking the background task on missing reply subject async-nats/src/service/mod.rs:390
3 🟠 info_request.reply also unwrapped without guard, same panic risk as ping handler async-nats/src/service/mod.rs:410

Run: https://product-hub.flamingo.so/admin/code-review
Run id: 06b1d724-91f9-455e-9eef-4cda91351dba

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

ClickUp task: CU-86akbh48z NATS async-nats and CI review findings (10 PRs)

… style ad-hoc io::Error instead of a typed *ErrorKind
@flamingo flamingo Bot changed the title fix(NATSRS-001-2): service/mod.rs Service::add returns Box<dyn Error> style ad-hoc io::Error instead of a typed *ErrorKind fix(NATSRS-001-2): CU-86akbh48z service/mod.rs Service::add returns Box<dyn Error> style ad-hoc io::Error instead of a typed *ErrorKind Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants