fix(adhoc-sweep-fixes): CU-86akbhh82 2 review findings across 2 files

[flamingo]

Closes 2 review findings across 2 files.

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

Warning

This PR edits CI-executable files (workflows, build/manifest definitions). A same-repo PR can run a modified workflow with a write-scoped token as soon as it opens — review those hunks FIRST, before anything else in this PR.

#	Fix confidence	Finding	Location
1	🟢 92 high	Message.length field is undocumented and untagged with serde attributes, unlike every other field	async-nats/src/message.rs:24
2	🔴 45 low — review closely	nats-server crate depends on async-nats "0.38" while workspace async-nats is at 0.42.0	nats-server/Cargo.toml:18

What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.

---

Run: https://product-hub.flamingo.so/admin/code-review
Run id: 4fa2224e-8528-443d-a51a-823c78308977

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

ClickUp task: CU-86akbhh82 NATS async-nats and CI review findings (9 PRs)

[flamingo]

🦩 What this fix changed, finding by finding

2 finding(s) fixed in this draft — 2 explained inline on the diff; 1 low-confidence hunk(s) need close review before merging.

[flamingo]

🦩 🟠 Message.length field is undocumented and untagged with serde attributes, unlike every other field

In async-nats/src/message.rs, added a doc comment (/// Length of the message in bytes.) and a #[serde(default)] attribute to the length: usize field of Message, matching the documented, deserialization-tolerant pattern used by the other fields. This ensures deserialization succeeds when length is absent (e.g. older serialized messages or wire data parsed before length is known), defaulting to 0 via Default::default() for usize.

🤖 Prompt for AI agents

In async-nats/src/message.rs around line 24, review and complete this code-review fix: Message.length field is undocumented and untagged with serde attributes, unlike every other field.
What the draft fix changed: In `async-nats/src/message.rs`, added a doc comment (`/// Length of the message in bytes.`) and a `#[serde(default)]` attribute to the `length: usize` field of `Message`, matching the documented, deserialization-tolerant pattern used by the other fields. This ensures deserialization succeeds when `length` is absent (e.g. older serialized messages or wire data parsed before length is known), defaulting to `0` via `Default::default()` for `usize`.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 92 high — react 👍/👎 to teach the reviewer

[flamingo]

🦩 🟠 nats-server crate depends on async-nats "0.38" while workspace async-nats is at 0.42.0

Changed the [dev-dependencies] entry for async-nats in nats-server/Cargo.toml from the version pin "0.38" to a path dependency { path = "../async-nats" }, so it resolves to the local workspace crate (whose Cargo.toml declares version 0.42.0) instead of a possibly-stale crates.io release. This assumes the async-nats crate lives at ../async-nats relative to nats-server, which is the conventional workspace layout but is unverified against the actual workspace Cargo.toml members list I was not given; if the relative path differs, the path would need adjustment.

🤖 Prompt for AI agents

In nats-server/Cargo.toml around line 18, review and complete this code-review fix: nats-server crate depends on async-nats "0.38" while workspace async-nats is at 0.42.0.
What the draft fix changed: Changed the `[dev-dependencies]` entry for `async-nats` in nats-server/Cargo.toml from the version pin `"0.38"` to a path dependency `{ path = "../async-nats" }`, so it resolves to the local workspace crate (whose Cargo.toml declares version 0.42.0) instead of a possibly-stale crates.io release. This assumes the async-nats crate lives at `../async-nats` relative to nats-server, which is the conventional workspace layout but is unverified against the actual workspace `Cargo.toml` members list I was not given; if the relative path differs, the path would need adjustment.
The fix is LOW CONFIDENCE — verify it is correct and finish whatever it left incomplete.

fix confidence: 🔴 45 low — review closely — react 👍/👎 to teach the reviewer