Skip to content

fix(MULTIPLA-002-2): CU-86akbhg68 named query keys for ticket options and ticket detail - #275

Merged
michaelassraf merged 1 commit into
mainfrom
ai-fix/multipla-002-2-ae38b118-55f2c88b
Sep 15, 2026
Merged

michaelassraf merged 1 commit into
mainfrom
ai-fix/multipla-002-2-ae38b118-55f2c88b

Conversation

@flamingo

@flamingo flamingo Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Closes 6 review findings across 4 files.

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

# Fix confidence Finding Location
1 🔴 55 low — review closely Inline ad-hoc query keys used instead of centralized admin-query-keys constants in use-ticket-options.ts src/app/(app)/tickets/hooks/use-ticket-options.ts:53
2 🔴 55 low — review closely Inline query key for assignee options bypasses admin-query-keys.ts src/app/(app)/tickets/hooks/use-ticket-options.ts:132
3 🔴 55 low — review closely Inline compound query key for ticket search options src/app/(app)/tickets/hooks/use-ticket-options.ts:209
4 🔴 35 low — review closely Inline query key array used for organizations list invalidation instead of a named constant src/app/(app)/customers/components/new-customer-page.tsx:289
5 🔴 35 low — review closely Inline queryKey array literal instead of a named constant from admin-query-keys.ts src/app/(app)/onboarding/components/book-call/use-onboarding-meeting-link.ts:39
6 🟢 90 high Inline query key array in use-ticket-detail.ts bypasses centralized query keys src/app/(app)/tickets/hooks/use-ticket-detail.ts:9

What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.


Run: https://product-hub.flamingo.so/admin/code-review
Run id: 55f2c88b-d771-4664-882e-531431771bd8

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

ClickUp task: CU-86akbhg68 Code review fixes: MULTIPLA-002-2 multi-repo review findings (3 PRs)

@flamingo flamingo Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 What this fix changed, finding by finding

6 finding(s) fixed in this draft — 6 explained inline on the diff; 5 low-confidence hunk(s) need close review before merging.

Comment thread src/app/(app)/tickets/hooks/use-ticket-options.ts
Comment thread src/app/(app)/tickets/hooks/use-ticket-options.ts
Comment thread src/app/(app)/tickets/hooks/use-ticket-options.ts
Comment thread src/app/(app)/customers/components/new-customer-page.tsx
Comment thread src/app/(app)/tickets/hooks/use-ticket-detail.ts
@flamingo flamingo Bot changed the title fix(MULTIPLA-002-2): 6 review findings across 4 files fix(MULTIPLA-002-2): CU-86akbhg68 6 review findings across 4 files Sep 3, 2026
@michaelassraf

Copy link
Copy Markdown
Contributor

@michaelassraf michaelassraf changed the title fix(MULTIPLA-002-2): CU-86akbhg68 6 review findings across 4 files fix(MULTIPLA-002-2): CU-86akbhg68 named query keys for ticket options and ticket detail Sep 15, 2026
@michaelassraf
michaelassraf force-pushed the ai-fix/multipla-002-2-ae38b118-55f2c88b branch from c5e4e42 to 1de3449 Compare September 15, 2026 18:03
@michaelassraf

Copy link
Copy Markdown
Contributor

Reviewed and rebuilt on current main (the old branch conflicted). Kept findings 1-3 (ticketOptionsQueryKeys builders, byte-identical keys) and 6 (ticketsQueryKeys.detail('__none__'), same key as the old literal). Dropped findings 4 and 5: both imported from @/hooks/admin-query-keys (adminQueryKeys.organizations.all, SCHEDULING_LINKS_KEY), a module that does not exist in this repo, so the build would have failed. tsc --noEmit passes with 0 errors.

@michaelassraf
michaelassraf marked this pull request as ready for review September 15, 2026 18:03
@michaelassraf
michaelassraf requested review from a team as code owners September 15, 2026 18:03
@michaelassraf
michaelassraf merged commit 8ffe2c0 into main Sep 15, 2026
19 of 21 checks passed
@michaelassraf
michaelassraf deleted the ai-fix/multipla-002-2-ae38b118-55f2c88b branch September 15, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant