fix(tickets): suppress live notification popups for the on-screen ticket chat. CU-86ak4az87 - #414
Closed
romanivan-flamingo wants to merge 1 commit into
Closed
romanivan-flamingo wants to merge 1 commit into
romanivan-flamingo wants to merge 1 commit into
Conversation
…ket chat. CU-86ak4az87 registerActiveDialogView was called only from the Mingo drawer, so a live message notification for a dialog was suppressed and auto-read while the Mingo drawer showed it, but popped on the ticket details page showing the same chat. Register the ticket's client-chat dialog as an active view while that chat is the visible pane, so isWatchingNotificationDialog treats both surfaces alike. Gated on clientChatOnScreen, not mount, so the Details tab still alerts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Contributor
🦩 Flamingo Code ReviewNo findings on the current head. Mode: advisory Need another pass? Commits pushed after this review are not reviewed automatically.
Prefer typing? Comment React 👍/👎 on inline comments to teach the reviewer. Started 2026-09-16 12:18 UTC · updated 2026-09-16 12:18 UTC · workflow run |
Contributor
Author
|
Consolidated into #350: this branch's commits are now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes live-notification suppression symmetric between the Mingo drawer and the ticket details page (86ak4az87, parent 86ajn8hnd).
registerActiveDialogView(from@/lib/active-dialog-views) was called from exactly one place - the Mingo realtime hook. So a live message notification carrying adialogIdwas suppressed (no popup) and auto-read while the Mingo drawer showed that dialog, but popped when the ticket details page showed the same client chat - the same event, two behaviours.Fix: register the ticket's client-chat dialog (
messageDialogId) as an active view while that chat is the visible pane, soisWatchingNotificationDialogin the notifications pipeline treats both surfaces alike. Done insideTicketNotificationsAutoReader(already the ticket page's notifications-concern component, already gated onclientChatOnScreen), so it is gated on the chat being on screen - not on mount - and the Details tab still alerts normally.Testing
npm run type-check, ESLint (ci config), Prettier - clean🤖 Generated with Claude Code