Skip to content

refactor(urls): the app URL comes from openframe-frontend-core's getDeploymentUrl - #416

Merged
pavlo-flamingo merged 1 commit into
mainfrom
refactor/app-url-from-lib
Sep 17, 2026
Merged

pavlo-flamingo merged 1 commit into
mainfrom
refactor/app-url-from-lib

Conversation

@michaelassraf

Copy link
Copy Markdown
Contributor

What

The app URL now comes from the one implementation in @flamingo-stack/openframe-frontend-core (0.0.645): getDeploymentUrl in platform-domains, the same rule the multi-platform hub uses (flamingo-stack/openframe-oss-lib#2219, flamingo-stack/multi-platform-hub#1296).

  • getAppUrl() in src/lib/utils.ts replaces getBaseUrl(), getAssetUrl() and getMetadataBaseUrl(). It supplies only the platform (openframe-dashboard) and this install's runtime NEXT_PUBLIC_APP_URL.
  • layout.tsx metadata (metadataBase, og:url), the platform config (url, logo, OG/Twitter images), asset paths and structured data all use it.
  • runtimeEnv.appUrl() returns '' when unset; runtimeEnv.devUrl() is removed.
  • Lib pin ^0.0.640^0.0.645 (0.0.645 removed the lib's getBaseUrl).
  • The generated inline docs for these modules are updated.

Resolution order (getAppUrl)

  1. Browser: the page's origin (was '', i.e. relative).
  2. NEXT_PUBLIC_APP_URL when set: a self-hosted install's own address wins.
  3. Vercel preview: the deployment's own VERCEL_URL.
  4. Production build: the registry URL, https://openframe.ai (was the hardcoded https://openframe.dev / https://openframe.ai).
  5. Development: NEXT_PUBLIC_DEV_URL, else http://localhost:${PORT:-3000}, matching npm run dev (was localhost:4000).

Checks

  • npm run generate-enums && relay-compiler, then tsc --noEmit: 0 errors.
  • ESLint (eslint.ci.mjs) and Prettier on the changed files: clean.

@michaelassraf
michaelassraf requested review from a team as code owners September 17, 2026 01:27
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

🦩 Flamingo Code Review

No findings on the current head.

Mode: advisory


Need another pass? Commits pushed after this review are not reviewed automatically.

  • Review the new commits — the commits added since this review
  • Review the whole diff again — ignoring what was already reviewed

Prefer typing? Comment @flamingo-review, or @flamingo-review full. To review every push on this pull request, add the flamingo-review-always label.

React 👍/👎 on inline comments to teach the reviewer.

Started 2026-09-17 01:27 UTC · updated 2026-09-17 01:27 UTC · workflow run

@pavlo-flamingo
pavlo-flamingo merged commit 2fee35e into main Sep 17, 2026
9 of 10 checks passed
@pavlo-flamingo
pavlo-flamingo deleted the refactor/app-url-from-lib branch September 17, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants