fix(OFJAVA-001): CU-86akeeczr Manual null/blank checks instead of StringUtils.hasText in UserInstalledAgentService - #2080
Draft
flamingo[bot] wants to merge 1 commit into
Draft
flamingo[bot] wants to merge 1 commit into
flamingo[bot] wants to merge 1 commit into
Conversation
…ext in UserInstalledAgentService
![flamingo[bot]](https://avatars.githubusercontent.com/in/3426709?s=60&v=4){kind=small}
| } | ||
|
|
||
| private void validateUserId(String userId) { | ||
| if (userId == null || userId.trim().isEmpty()) { |
Contributor
Author
There was a problem hiding this comment.
🦩 🟠 Manual null/blank checks instead of StringUtils.hasText in UserInstalledAgentService
In validateUserId, replaced the manual userId == null || userId.trim().isEmpty() check with !hasText(userId), using a static import of org.springframework.util.StringUtils.hasText. Also applied the same utility to validateAgentType for consistency with the identical pattern present there, since it is the same code smell and both methods are adjacent and trivially covered by the same fix.
🤖 Prompt for AI agents
In openframe-client-core/src/main/java/com/openframe/client/service/UserInstalledAgentService.java around line 75, review and complete this code-review fix: Manual null/blank checks instead of StringUtils.hasText in UserInstalledAgentService.
What the draft fix changed: In `validateUserId`, replaced the manual `userId == null || userId.trim().isEmpty()` check with `!hasText(userId)`, using a static import of `org.springframework.util.StringUtils.hasText`. Also applied the same utility to `validateAgentType` for consistency with the identical pattern present there, since it is the same code smell and both methods are adjacent and trivially covered by the same fix.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟢 90 high — react 👍/👎 to teach the reviewer
flamingo
Bot
changed the title
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes findings from rule OFJAVA-001 — Manual null/blank checks instead of StringUtils.hasText in UserInstalledAgentService.
Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.
openframe-client-core/src/main/java/com/openframe/client/service/UserInstalledAgentService.java:75What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.
Run: https://product-hub.flamingo.so/admin/code-review
Run id:
4f0d6344-55d4-49de-bc86-cac2510f432fMerging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.
ClickUp task: CU-86akeeczr OpenFrame lib batch review findings sweep 2 (13 PRs)