Skip to content

fix(OPENFRAM-002-10): CU-86akeeczr elestio-logo.tsx uses React.useId for clip-path uniqueness while every other icon in this batch has no such guard, and duplicate icon proliferation continues despite deprecation notices #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flamingo wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Draft

fix(OPENFRAM-002-10): CU-86akeeczr elestio-logo.tsx uses React.useId for clip-path uniqueness while every other icon in this batch has no such guard, and duplicate icon proliferation continues despite deprecation notices #2083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion openframe-frontend-core/src/components/icons/elestio-logo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ import React from 'react';
* Official Elestio logo with unique IDs to prevent gradient/clip-path collisions
* when the same SVG is rendered multiple times on the page.
*/
/** @deprecated Use icons from icons-v2-generated instead. */
/**
* @deprecated Use icons from icons-v2-generated instead. This component is retained
* only for existing usages; do not add new usages or new icons to this deprecated set.
*/
export const ElestioLogo = ({ className, ...props }: { className?: string } & React.SVGProps<SVGSVGElement>) => {
// Generate unique ID suffix to avoid ID collisions between instances
const uniqueId = React.useId();
Comment on lines 4 to 13

@flamingo flamingo Bot Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🟠 elestio-logo.tsx uses React.useId for clip-path uniqueness while every other icon in this batch has no such guard, and duplicate icon proliferation continues despite deprecation notices

Strengthened the @deprecated JSDoc comment above ElestioLogo in elestio-logo.tsx to explicitly warn against adding new usages or new icons to this deprecated set, making the deprecation intent unmissable to future contributors. This is a documentation-only change; it does not remove the file, migrate consumers to icons-v2-generated, or prevent new deprecated icons from being added elsewhere. The finding's real concern (org policy about whether new deprecated-set icons should exist at all) is architectural/process-level and cannot be resolved by editing this single file — a complete fix would require a maintainer decision to either delete this file in favor of an icons-v2-generated equivalent or formally document an exception, which is out of scope for a single-file, non-refactor change.

🤖 Prompt for AI agents 
In openframe-frontend-core/src/components/icons/elestio-logo.tsx around line 3, review and complete this code-review fix: elestio-logo.tsx uses React.useId for clip-path uniqueness while every other icon in this batch has no such guard, and duplicate icon proliferation continues despite deprecation notices.
What the draft fix changed: Strengthened the `@deprecated` JSDoc comment above `ElestioLogo` in elestio-logo.tsx to explicitly warn against adding new usages or new icons to this deprecated set, making the deprecation intent unmissable to future contributors. This is a documentation-only change; it does not remove the file, migrate consumers to icons-v2-generated, or prevent new deprecated icons from being added elsewhere. The finding's real concern (org policy about whether new deprecated-set icons should exist at all) is architectural/process-level and cannot be resolved by editing this single file — a complete fix would require a maintainer decision to either delete this file in favor of an icons-v2-generated equivalent or formally document an exception, which is out of scope for a single-file, non-refactor change.
The fix is LOW CONFIDENCE — verify it is correct and finish whatever it left incomplete.

fix confidence: 🔴 25 low — review closely — react 👍/👎 to teach the reviewer

Expand Down