Skip to content

fix(OPENFRAM-008-2): CU-86akeeczr MoreActionsMenu is a deprecated component still fully implemented rather than re-exported from ActionsMenu family - #2087

Draft
flamingo[bot] wants to merge 1 commit into
mainfrom
ai-fix/openfram-008-2-061957df-4f0d6344
Draft

flamingo[bot] wants to merge 1 commit into
mainfrom
ai-fix/openfram-008-2-061957df-4f0d6344

Conversation

@flamingo

@flamingo flamingo Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Closes findings from rule OPENFRAM-008-2 — MoreActionsMenu is a deprecated component still fully implemented rather than re-exported from ActionsMenu family.

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

# Fix confidence Finding Location
1 🔴 30 low — review closely MoreActionsMenu is a deprecated component still fully implemented rather than re-exported from ActionsMenu family openframe-frontend-core/src/components/ui/more-actions-menu.tsx:10

What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.


Run: https://product-hub.flamingo.so/admin/code-review
Run id: 4f0d6344-55d4-49de-bc86-cac2510f432f

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

ClickUp task: CU-86akeeczr OpenFrame lib batch review findings sweep 2 (13 PRs)

…fully implemented rather than re-exported from ActionsMenu family

@flamingo flamingo Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 What this fix changed, finding by finding

1 finding(s) fixed in this draft — 1 explained inline on the diff; 1 low-confidence hunk(s) need close review before merging.

import { DropdownMenu, DropdownMenuContent, DropdownMenuItem, DropdownMenuTrigger } from './dropdown-menu';
import { ActionsMenuDropdown, type ActionsMenuItemConfig } from './actions-menu';

/**

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🟠 MoreActionsMenu is a deprecated component still fully implemented rather than re-exported from ActionsMenu family

Rewrote MoreActionsMenu in more-actions-menu.tsx to be a thin wrapper delegating rendering to ActionsMenuDropdown from ./actions-menu, mapping MoreActionsItem[] to an assumed ActionsMenuItemConfig[] shape and forwarding align/side/sideOffset/className (as triggerClassName)/contentClassName/ariaLabel/trigger (as customTrigger)/open/onOpenChange/onCloseAutoFocus. This is UNVERIFIED because I cannot see the actual exported API of ./actions-menu (prop names like triggerClassName, customTrigger, ariaLabel, or the exact shape/name of ActionsMenuItemConfig are guesses based on the deprecation-comment wording); a complete, safe fix requires opening ./actions-menu to confirm the real prop and type names and adjust the mapping/forwarding accordingly, and to verify styling/keyboard parity claims in the finding are actually satisfied by the real component's defaults.

🤖 Prompt for AI agents
In openframe-frontend-core/src/components/ui/more-actions-menu.tsx around line 10, review and complete this code-review fix: MoreActionsMenu is a deprecated component still fully implemented rather than re-exported from ActionsMenu family.
What the draft fix changed: Rewrote `MoreActionsMenu` in more-actions-menu.tsx to be a thin wrapper delegating rendering to `ActionsMenuDropdown` from `./actions-menu`, mapping `MoreActionsItem[]` to an assumed `ActionsMenuItemConfig[]` shape and forwarding `align`/`side`/`sideOffset`/`className` (as `triggerClassName`)/`contentClassName`/`ariaLabel`/`trigger` (as `customTrigger`)/`open`/`onOpenChange`/`onCloseAutoFocus`. This is UNVERIFIED because I cannot see the actual exported API of `./actions-menu` (prop names like `triggerClassName`, `customTrigger`, `ariaLabel`, or the exact shape/name of `ActionsMenuItemConfig` are guesses based on the deprecation-comment wording); a complete, safe fix requires opening `./actions-menu` to confirm the real prop and type names and adjust the mapping/forwarding accordingly, and to verify styling/keyboard parity claims in the finding are actually satisfied by the real component's defaults.
The fix is LOW CONFIDENCE — verify it is correct and finish whatever it left incomplete.

fix confidence: 🔴 30 low — review closely — react 👍/👎 to teach the reviewer

@flamingo flamingo Bot changed the title fix(OPENFRAM-008-2): MoreActionsMenu is a deprecated component still fully implemented rather than re-exported from ActionsMenu family fix(OPENFRAM-008-2): CU-86akeeczr MoreActionsMenu is a deprecated component still fully implemented rather than re-exported from ActionsMenu family Sep 8, 2026
@michaelassraf

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant