fix(rmm): stamp the package manager on the bootstrap execution row - #2146
Open
semen-flamingo wants to merge 1 commit into
Open
semen-flamingo wants to merge 1 commit into
semen-flamingo wants to merge 1 commit into
Conversation
#2098 landed before #2143 added ScriptExecution.packageManager, so bootstrap rows carried none and their metrics read manager=NONE. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9CaivesWZpswt111BooyK
Contributor
🦩 Flamingo Code ReviewNo findings on the current head. Mode: advisory Need another pass? Commits pushed after this review are not reviewed automatically.
Prefer typing? Comment React 👍/👎 on inline comments to teach the reviewer. Started 2026-09-10 15:03 UTC · updated 2026-09-10 15:04 UTC · workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One line in
PackageManagerBootstrapService.dispatch:.packageManager(packageManager)on the persisted row.#2098 merged before #2143 added
ScriptExecution.packageManager, so bootstrap rows carry none and their metrics readmanager=NONE. The Software Management alerts and board (saas-shared #2064) split bootstrap results by manager, so this needs to land before the next oss-lib release.The existing
dispatchesOnFirstReporttest asserts the field.🤖 Generated with Claude Code
https://claude.ai/code/session_01K9CaivesWZpswt111BooyK