fix(OPENFRAM-002-4): CU-86akbhg46 Kafka topic name hardcoded as bare string for outbound topics instead of nested 'name' key - #2306
Draft
flamingo[bot] wants to merge 1 commit into
Conversation
…tbound topics instead of nested 'name' key
Comment on lines
65
to
+75
| logs-events: | ||
| name: logs.events | ||
| outbound: | ||
| integrated-tool-events: integrated-tool.events.pinot | ||
| devices-topic: devices-topic | ||
| integrated-tool-events: | ||
| name: integrated-tool.events.pinot | ||
| devices-topic: | ||
| name: devices-topic | ||
|
|
||
| integration: | ||
| tool: | ||
| enabled: true No newline at end of file | ||
| enabled: true |
Contributor
Author
There was a problem hiding this comment.
🦩 🔴 Kafka topic name hardcoded as bare string for outbound topics instead of nested 'name' key
In configs/base/openframe-stream.yml under openframe.oss-tenant.kafka.topics.outbound, changed the bare scalar entries integrated-tool-events: integrated-tool.events.pinot and devices-topic: devices-topic to nested mappings with a name key (integrated-tool-events.name: integrated-tool.events.pinot and devices-topic.name: devices-topic), matching the inbound topics' structure so property paths like ${openframe.oss-tenant.kafka.topics.outbound.integrated-tool-events.name} resolve correctly.
🤖 Prompt for AI agents
In configs/base/openframe-stream.yml around line 60, review and complete this code-review fix: Kafka topic name hardcoded as bare string for outbound topics instead of nested 'name' key.
What the draft fix changed: In `configs/base/openframe-stream.yml` under `openframe.oss-tenant.kafka.topics.outbound`, changed the bare scalar entries `integrated-tool-events: integrated-tool.events.pinot` and `devices-topic: devices-topic` to nested mappings with a `name` key (`integrated-tool-events.name: integrated-tool.events.pinot` and `devices-topic.name: devices-topic`), matching the inbound topics' structure so property paths like `${openframe.oss-tenant.kafka.topics.outbound.integrated-tool-events.name}` resolve correctly.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟢 90 high — react 👍/👎 to teach the reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes findings from rule OPENFRAM-002-4 — Kafka topic name hardcoded as bare string for outbound topics instead of nested 'name' key.
Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.
configs/base/openframe-stream.yml:60What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.
Run: https://product-hub.flamingo.so/admin/code-review
Run id:
12cfe861-f81f-494f-94f7-58bce1e4ddc7Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.
ClickUp task: CU-86akbhg46 OpenFrame Kubernetes manifest hardening (9 PRs)