Skip to content

fix(OPENFRAM-002-4): CU-86akbhg46 Kafka topic name hardcoded as bare string for outbound topics instead of nested 'name' key - #2306

Draft
flamingo[bot] wants to merge 1 commit into
mainfrom
ai-fix/openfram-002-4-354812d7-12cfe861
Draft

flamingo[bot] wants to merge 1 commit into
mainfrom
ai-fix/openfram-002-4-354812d7-12cfe861

Conversation

@flamingo

@flamingo flamingo Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Closes findings from rule OPENFRAM-002-4 — Kafka topic name hardcoded as bare string for outbound topics instead of nested 'name' key.

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

# Fix confidence Finding Location
1 🟢 90 high Kafka topic name hardcoded as bare string for outbound topics instead of nested 'name' key configs/base/openframe-stream.yml:60

What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.


Run: https://product-hub.flamingo.so/admin/code-review
Run id: 12cfe861-f81f-494f-94f7-58bce1e4ddc7

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

ClickUp task: CU-86akbhg46 OpenFrame Kubernetes manifest hardening (9 PRs)

@flamingo flamingo Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 What this fix changed, finding by finding

1 finding(s) fixed in this draft — 1 explained inline on the diff.

Comment on lines 65 to +75
logs-events:
name: logs.events
outbound:
integrated-tool-events: integrated-tool.events.pinot
devices-topic: devices-topic
integrated-tool-events:
name: integrated-tool.events.pinot
devices-topic:
name: devices-topic

integration:
tool:
enabled: true No newline at end of file
enabled: true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🔴 Kafka topic name hardcoded as bare string for outbound topics instead of nested 'name' key

In configs/base/openframe-stream.yml under openframe.oss-tenant.kafka.topics.outbound, changed the bare scalar entries integrated-tool-events: integrated-tool.events.pinot and devices-topic: devices-topic to nested mappings with a name key (integrated-tool-events.name: integrated-tool.events.pinot and devices-topic.name: devices-topic), matching the inbound topics' structure so property paths like ${openframe.oss-tenant.kafka.topics.outbound.integrated-tool-events.name} resolve correctly.

🤖 Prompt for AI agents
In configs/base/openframe-stream.yml around line 60, review and complete this code-review fix: Kafka topic name hardcoded as bare string for outbound topics instead of nested 'name' key.
What the draft fix changed: In `configs/base/openframe-stream.yml` under `openframe.oss-tenant.kafka.topics.outbound`, changed the bare scalar entries `integrated-tool-events: integrated-tool.events.pinot` and `devices-topic: devices-topic` to nested mappings with a `name` key (`integrated-tool-events.name: integrated-tool.events.pinot` and `devices-topic.name: devices-topic`), matching the inbound topics' structure so property paths like `${openframe.oss-tenant.kafka.topics.outbound.integrated-tool-events.name}` resolve correctly.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 90 high — react 👍/👎 to teach the reviewer

@flamingo flamingo Bot changed the title fix(OPENFRAM-002-4): Kafka topic name hardcoded as bare string for outbound topics instead of nested 'name' key fix(OPENFRAM-002-4): CU-86akbhg46 Kafka topic name hardcoded as bare string for outbound topics instead of nested 'name' key Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants