fix(OPENFRAM-002-4): CU-86akdypzd Kafka topic name hardcoded instead of using openframe.oss-tenant.kafka.topics hierarchy in openframe-client.yml stream bindings

[flamingo]

Closes findings from rule OPENFRAM-002-4 — Kafka topic name hardcoded instead of using openframe.oss-tenant.kafka.topics hierarchy in openframe-client.yml stream bindings.

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

#	Fix confidence	Finding	Location
1	🔴 45 low — review closely	Kafka topic name hardcoded instead of using openframe.oss-tenant.kafka.topics hierarchy in openframe-client.yml stream bindings	configs/base/openframe-client.yml:42

What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.

---

Run: https://product-hub.flamingo.so/admin/code-review
Run id: c1688cba-c9bc-481b-b917-2b7f45403ab4

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

ClickUp task: CU-86akdypzd OpenFrame Kafka config hardcoding fixes (5 PRs)

[flamingo]

🦩 What this fix changed, finding by finding

1 finding(s) fixed in this draft — 1 explained inline on the diff; 1 low-confidence hunk(s) need close review before merging.

[flamingo]

🦩 🔴 Kafka topic name hardcoded instead of using openframe.oss-tenant.kafka.topics hierarchy in openframe-client.yml stream bindings

In spring.cloud.stream.bindings (machineConnectedConsumer-in-0, machineDisconnectionConsumer-in-0, toolConnectionConsumer-in-0), replaced hardcoded literal destination strings with property placeholders ${openframe.oss-tenant.kafka.topics.inbound.<name>.name}, and added a corresponding openframe.oss-tenant.kafka.topics.inbound section (machine-connected, machine-disconnected, tool-connection) at the bottom of the file preserving the original literal subject values. This mirrors the outbound topic hierarchy already present. Risk/unverified: I do not have visibility into openframe-stream.yml/openframe-management.yml to confirm the exact key names (machine-connected, machine-disconnected, tool-connection) match the naming convention used by sibling services under openframe.oss-tenant.kafka.topics.inbound.*.name; if sibling configs use different key names for these same logical topics, this introduces a mismatch and the keys would need renaming to align. A complete fix requires cross-checking those sibling files.

🤖 Prompt for AI agents

In configs/base/openframe-client.yml around line 42, review and complete this code-review fix: Kafka topic name hardcoded instead of using openframe.oss-tenant.kafka.topics hierarchy in openframe-client.yml stream bindings.
What the draft fix changed: In `spring.cloud.stream.bindings` (machineConnectedConsumer-in-0, machineDisconnectionConsumer-in-0, toolConnectionConsumer-in-0), replaced hardcoded literal destination strings with property placeholders `${openframe.oss-tenant.kafka.topics.inbound.<name>.name}`, and added a corresponding `openframe.oss-tenant.kafka.topics.inbound` section (machine-connected, machine-disconnected, tool-connection) at the bottom of the file preserving the original literal subject values. This mirrors the `outbound` topic hierarchy already present. Risk/unverified: I do not have visibility into `openframe-stream.yml`/`openframe-management.yml` to confirm the exact key names (`machine-connected`, `machine-disconnected`, `tool-connection`) match the naming convention used by sibling services under `openframe.oss-tenant.kafka.topics.inbound.*.name`; if sibling configs use different key names for these same logical topics, this introduces a mismatch and the keys would need renaming to align. A complete fix requires cross-checking those sibling files.
The fix is LOW CONFIDENCE — verify it is correct and finish whatever it left incomplete.

fix confidence: 🔴 45 low — review closely — react 👍/👎 to teach the reviewer