Skip to content

fix(OPENFRAM-004-13): CU-86akeeczx emit_to failure log in notification_actions.rs missing bracketed module prefix #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flamingo wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Draft

fix(OPENFRAM-004-13): CU-86akeeczx emit_to failure log in notification_actions.rs missing bracketed module prefix #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src-tauri/src/notification_actions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ fn announce_dialog_change(app: &AppHandle, context: &ActionContext) {
DIALOG_CHANGED_EVENT,
serde_json::json!({ "dialogId": dialog_id }),
) {
log::warn!("emit {DIALOG_CHANGED_EVENT}: {e}");

@flamingo flamingo Bot Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🟠 emit_to failure log in notification_actions.rs missing bracketed module prefix

Added the [notifications] bracketed module prefix to the log::warn! call in announce_dialog_change (around the app.emit_to error branch), changing log::warn!("emit {DIALOG_CHANGED_EVENT}: {e}"); to log::warn!("[notifications] emit {DIALOG_CHANGED_EVENT}: {e}");, matching the convention used by every other log call site in this file.

🤖 Prompt for AI agents 
In src-tauri/src/notification_actions.rs around line 257, review and complete this code-review fix: emit_to failure log in notification_actions.rs missing bracketed module prefix.
What the draft fix changed: Added the `[notifications]` bracketed module prefix to the `log::warn!` call in `announce_dialog_change` (around the `app.emit_to` error branch), changing `log::warn!("emit {DIALOG_CHANGED_EVENT}: {e}");` to `log::warn!("[notifications] emit {DIALOG_CHANGED_EVENT}: {e}");`, matching the convention used by every other log call site in this file.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 95 high — react 👍/👎 to teach the reviewer

log::warn!("[notifications] emit {DIALOG_CHANGED_EVENT}: {e}");
}
}

Expand Down
Loading