-
Notifications
You must be signed in to change notification settings - Fork 0
fix(REGISTRY-001): CU-86akbhhc9 2 review findings in regsync-config.yaml #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -186,14 +186,6 @@ sync: | |
| # Includes: Debezium, Apache Pinot | ||
| # --------------------------------------------------------------------------- | ||
|
|
||
| - source: quay.io/debezium/connect | ||
| target: ${TARGET_REGISTRY}/debezium/connect | ||
| type: repository | ||
| tags: | ||
| allow: | ||
| - '2\.([5-9]|[0-9]{2,})\.[0-9]+\.Final' | ||
| - '[3-9]\.[0-9]+\.[0-9]+\.Final' | ||
|
|
||
| - source: quay.io/debezium/connect | ||
| target: ${TARGET_REGISTRY}/debezium/connect | ||
| type: repository | ||
|
|
@@ -202,18 +194,22 @@ sync: | |
| - ">=3.0.0" | ||
| allow: | ||
| - '[0-9]+\.[0-9]+\.[0-9]+' | ||
| - '[0-9]+\.[0-9]+\.[0-9]+\.Final' | ||
|
|
||
| - source: docker.io/apachepinot/pinot | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 𦩠π apachepinot/pinot allows 'latest' tag without justification comment Added inline comments above/beside the two π€ Prompt for AI agentsfix confidence: π‘ 70 medium β react π/π to teach the reviewer |
||
| target: ${TARGET_REGISTRY}/apachepinot/pinot | ||
| type: repository | ||
| tagSets: | ||
| - allow: | ||
| # "latest" retained: upstream publishes rolling SNAPSHOT/latest builds | ||
| # used for pre-release testing; pinned alongside explicit SNAPSHOT tag. | ||
| - "latest" | ||
| - "1.5.0-SNAPSHOT-43142cdc37-20251204" | ||
| - semverRange: | ||
| - ">=0.1.0" | ||
| allow: | ||
| - '[0-9]+\.[0-9]+\.[0-9]+' | ||
| # "latest" retained here for the same reason as above. | ||
| - latest | ||
|
|
||
| # --------------------------------------------------------------------------- | ||
|
|
@@ -854,3 +850,4 @@ sync: | |
| - ">=2.23.6" | ||
| allow: | ||
| - '[0-9]+\.[0-9]+\.[0-9]+' | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
𦩠π΄ quay.io/debezium/connect has a duplicate sync entry with conflicting tag policies
Merged the two duplicate
quay.io/debezium/connectsync blocks in thesync:list into a single entry with onesemverRange: >=3.0.0floor and combinedallowpatterns ('[0-9]+\.[0-9]+\.[0-9]+'and'[0-9]+\.[0-9]+\.[0-9]+\.Final'), removing the first unbounded entry that allowed 2.x.Finaltags with no semverRange floor, exactly per the suggested fix.π€ Prompt for AI agents
fix confidence: π‘ 85 medium β react π/π to teach the reviewer