Skip to content

Add support for storing charts in GCS. #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kylieCat wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for storing charts in GCS. #88

kylieCat wants to merge 2 commits into from

Conversation

@kylieCat
Copy link

@kylieCat kylieCat commented Oct 18, 2019

  • Charts can be in public or private GCS buckets. Uses APPLICATION_DEFAULT_CREDENTIALS to authenticate
  • Usage:
chart_options = {
    "name":"my-chart",
    "source": {
    	"type": "repo",
        "location": f"gs://{bucket_name}"

     }
}

chart = ChartBuilder(chart_options)

@kylie-sre
Add support for storing charts in GCS.
f53cdd1 
- Charts can be in public or private GCS buckets. Uses APPLICATION_DEFAULT_CREDENTIALS to authenticate
- Usage:

```
chart_options = {
    "name":"my-chart",
    "source": {
    	"type": "repo",
        "location": f"gs://{bucket_name}"

     }
}

chart = ChartBuilder(chart_options)
@yanivoliver
Copy link
Collaborator

yanivoliver commented Oct 20, 2019

Hi @kylie-a - the code looks good, but please add tests for the added functionality.

@yanivoliver
Copy link
Collaborator

yanivoliver commented Apr 1, 2020

You didn't actually mock mocked_gcsclient in the tests. They do not pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kylieCat @yanivoliver @kylie-sre