Skip to content

Remove force kill listener cleanup #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
canercidam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove force kill listener cleanup #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions playground/local_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,18 +283,12 @@ func (d *LocalRunner) sendExitError(err error) {
}

func (d *LocalRunner) Stop(keepResources bool) error {
forceKillCtx, cancel := context.WithCancel(context.Background())
defer cancel()
// Keep an eye on the force kill requests.
go func(ctx context.Context) {
select {
case <-ctx.Done():
return
case <-mainctx.GetForceKillCtx().Done():
d.stopAllProcessesWithSignal(os.Kill)
ForceKillSession(d.manifest.ID, keepResources)
}
}(forceKillCtx)
go func() {
<-mainctx.GetForceKillCtx().Done()
d.stopAllProcessesWithSignal(os.Kill)
ForceKillSession(d.manifest.ID, keepResources)
}()
Comment on lines +287 to +291
Copy link
Contributor

@claude claude bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goroutine will never terminate during normal (non-force-kill) shutdown. The forceKillCtx from mainctx is only cancelled on the 3rd interrupt signal. In the common case (graceful exit), the goroutine blocks on this channel indefinitely.

The previous code used a local context.WithCancel + defer cancel() to ensure the goroutine was cleaned up when Stop() returned. Without that, this goroutine leaks for the remainder of the process lifetime.

Since this is a CLI tool that exits shortly after Stop(), this is practically benign — the leaked goroutine gets cleaned up by process exit. But it's worth noting that the old code was more correct in terms of resource management. If Stop() were ever called in a context where the process continues (e.g., tests, session rotation), the leak would accumulate.

// Kill all the processes ran by playground on the host.
// Possible to make a more graceful exit with os.Interrupt here
// but preferring a quick exit for now.
Expand Down