Skip to content

feat: make buildernet vm data disk size configurable with env var#392

Merged
canercidam merged 1 commit intomainfrom
fryd/buildernet-configurable-vm-data-disk-size
Mar 4, 2026
Merged

feat: make buildernet vm data disk size configurable with env var#392
canercidam merged 1 commit intomainfrom
fryd/buildernet-configurable-vm-data-disk-size

Conversation

@fkondej
Copy link
Contributor

@fkondej fkondej commented Mar 4, 2026

No description provided.

@fkondej fkondej self-assigned this Mar 4, 2026
@fkondej fkondej requested a review from canercidam as a code owner March 4, 2026 09:33
@claude
Copy link
Contributor

claude bot commented Mar 4, 2026

Claude finished @fkondej's task in 1m 1s —— View job


PR Review: Make BuilderNet VM data disk size configurable

  • Gather context and review changes
  • Post review feedback

The change itself is clean and correct — replacing the hardcoded 100G with ${VM_DATA_DISK_SIZE:-100G} is the right pattern and the default preserves backward compatibility.

One issue: missing documentation. The new VM_DATA_DISK_SIZE env var needs to be added to:

  1. The script header comment (lines 8-9 of prepare.sh)
  2. The README's Environment Variables table

See inline comment for details.

@canercidam canercidam merged commit 1528441 into main Mar 4, 2026
10 checks passed
@canercidam canercidam deleted the fryd/buildernet-configurable-vm-data-disk-size branch March 4, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants