Skip to content

feat: set default BUILDERNET_IMAGE to url and add readyz.sh helper script#393

Merged
canercidam merged 1 commit intomainfrom
fryd/buildernet-default-image-url-and-readyz-script
Mar 4, 2026
Merged

feat: set default BUILDERNET_IMAGE to url and add readyz.sh helper script#393
canercidam merged 1 commit intomainfrom
fryd/buildernet-default-image-url-and-readyz-script

Conversation

@fkondej
Copy link
Contributor

@fkondej fkondej commented Mar 4, 2026

No description provided.

@fkondej fkondej self-assigned this Mar 4, 2026
@fkondej fkondej requested a review from canercidam as a code owner March 4, 2026 10:30
@claude
Copy link
Contributor

claude bot commented Mar 4, 2026

Claude finished @fkondej's task in 1m 3s —— View job


Review Summary

  • Read changed files and diff
  • Review code quality and correctness
  • Post review feedback

Two issues flagged as inline comments:

  1. readyz.sh missing QEMU liveness check — Unlike the readiness loop in start.sh, the new readyz.sh doesn't verify the QEMU process is still alive. If the VM crashes, it will silently poll for the full timeout (300s) instead of failing fast.

  2. Hardcoded dev image URL in playground.yaml — The default BUILDERNET_IMAGE points to a specific dev build (dev-20260303-3059b761). This will go stale and need frequent bumps. A latest redirect URL would be more maintainable.

Everything else (README updates, script structure, env variable handling) looks good.

@canercidam canercidam merged commit a06b467 into main Mar 4, 2026
19 checks passed
@canercidam canercidam deleted the fryd/buildernet-default-image-url-and-readyz-script branch March 4, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants