add golangci-lint config#18
Open
tylerauerbeck wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add golangci-lint config
This adds an initial
golangci-lintconfig (copied from Nebraska) to begin linting this repo and apply various best practices.How to use
golangci-lint run -v ./...Testing done
I ran this and begin fixing the various lints that were found. However, there are quite a few and some of them will likely require some changes that would impact if other upstream packages make use of them. To make these changes safely without impacting existing applications/users, I would recommend following the steps mentioned here.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.