Warn when a seed is specified but adaptive stopping is still enabled - #90
Merged
Merged
Conversation
bob-carpenter
requested changes
Aug 7, 2026
| num_params = init_shape[0] | ||
|
|
||
| seed = prepare_seed(seed) | ||
| is_adaptive = num_chains > 1 and ( |
Collaborator
There was a problem hiding this comment.
is_adaptive is a confusing name here given there's multiple adaptations in play. Can we call this something like is_monitored?
And how often do we run if is_monitored is False, but min_warmup_iter != max_warup_iter? Do we just take the minimum?
Collaborator
Author
There was a problem hiding this comment.
And how often do we run if is_monitored is False, but min_warmup_iter != max_warup_iter? Do we just take the minimum?
What do you mean by this?
bob-carpenter
approved these changes
Aug 11, 2026
bob-carpenter
left a comment
bob-carpenter
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for factoring out an adaptivity function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.