Fix crash when inserting newlines rapidly#578
Open
bilaldev05 wants to merge 1 commit intofleather-editor:masterfrom
Open
Fix crash when inserting newlines rapidly#578bilaldev05 wants to merge 1 commit intofleather-editor:masterfrom
bilaldev05 wants to merge 1 commit intofleather-editor:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an assertion failure in editable_box.dart when rapidly inserting new lines.
Under fast input, the document model can grow faster than the render tree updates, causing childAtPosition() to return null.
Instead of asserting, we now gracefully fallback to the last available child.
Steps to reproduce:
After fix:
No assertion occurs and scrolling works normally.
Tested on:
Android (Pixel Fold)
Flutter 3.41.0