Skip to content

Surface wikidata misses + default to gemini-flash-lite #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fleveque merged 1 commit into from
May 16, 2026
Merged

Surface wikidata misses + default to gemini-flash-lite #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config.example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ llm:
- "openai"
gemini:
api_key: "" # or set LOGO_LLM_GEMINI_API_KEY env var
model: "gemini-2.5-flash" # free tier — 15 req/min
model: "gemini-2.5-flash-lite" # free tier — 1000 req/day vs flash's 20/day
anthropic:
api_key: "" # or set LOGO_LLM_ANTHROPIC_API_KEY env var
model: "claude-sonnet-4-5-20250929"
Expand Down
4 changes: 3 additions & 1 deletion internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ func Load(configPath string) (*Config, error) {
v.SetDefault("llm.provider_order", []string{"gemini", "anthropic", "openai"})
v.SetDefault("llm.anthropic.model", "claude-sonnet-4-5-20250929")
v.SetDefault("llm.openai.model", "gpt-4o")
v.SetDefault("llm.gemini.model", "gemini-2.5-flash")
// flash-lite gets 1000 free req/day vs flash's 20 — and Wikidata covers
// the major-company case now, so LLM is mostly a long-tail fallback.
v.SetDefault("llm.gemini.model", "gemini-2.5-flash-lite")
v.SetDefault("llm.rate_per_minute", 10)
v.SetDefault("github.repos", []string{
"davidepalazzo/ticker-logos",
Expand Down
6 changes: 5 additions & 1 deletion internal/service/logo_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,12 @@ func (s *LogoService) acquire(ctx context.Context, symbol, companyName string) (
)
return result, nil
}
s.logger.Debug("wikidata provider miss",
// Info (not Debug) so we can see in production whether Wikidata was
// even reachable for a given ticker and why it bailed (missing
// company_name vs no Q-entity vs no P154 vs download fail).
s.logger.Info("wikidata provider miss",
zap.String("symbol", symbol),
zap.String("company_name", companyName),
zap.Error(err),
)
}
Expand Down
Loading