feat(settings): clearer community-sharing UX (drop "slug", live URL preview)#100
Merged
Conversation
…e URL preview)
Reworks the /settings community-sharing card per founder feedback:
- "slug" -> "Your public link" (the word "slug" isn't widely known);
the blurb is rewritten in plain language.
- Live URL preview (← legacy): as you type a link, the resulting
quantic.es/p/<link> (and /r/<link> when radar sharing is on) is shown
via verified routes, reflecting the actual toggle state.
- Toggles are hidden until a link is entered, instead of leaving a
"share my portfolio" box checked while the link field is empty
(which shared nothing and read as broken). Hiding — not disabling —
avoids the Phoenix checkbox gotcha where a disabled box still submits
its hidden "false" companion and would silently flip the flag.
Reactive via a new phx-change handler; ~4 strings translated x6.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Founder feedback on the
/settingscommunity-sharing card: "slug" isn't a widely-known word, legacy showed your future URLs, and a checked "share my portfolio" box with an empty link field reads as broken (it shares nothing).Changes
…/p/<link>(and…/r/<link>when radar sharing is on) renders via verified routes, reflecting the actual toggle state.falsecompanion, so typing a link could silently flipshare_portfolioto false. Hiding keeps the field absent from params → the existing value is preserved.Reactive via a new
phx-changehandler; the slug normalization is mirrored for the preview (the real normalize runs in the changeset on save).Tests
mix precommitgreen — 400 passed. The sharing test now covers: empty link → toggles hidden + hint; typing a link → toggles + URL preview appear. ~4 new strings translated ×6.🤖 Generated with Claude Code