Expose currency field in quote results#12
Merged
Merged
Conversation
Yahoo's quote payload includes the listing currency; pass it through so callers can support multi-currency portfolios without re-querying. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
currencyfield throughbuild_quote_hashso callers can support multi-currency portfolios without a second request.Why
Downstream apps (e.g. dividend-portfolio) need the listing currency to render non-USD stocks correctly and to split portfolio totals per currency. Yahoo already returns it on every quote — we were just discarding it.
Test plan
bundle exec rspec— 63 examples, 0 failures (includes new "when the response includes a currency" case).bundle exec rubocop— clean.🤖 Generated with Claude Code