Add Stock.get_fx_rate for currency pair lookups#13
Merged
Conversation
Wraps Yahoo's <FROM><TO>=X quote symbol and returns just the regularMarketPrice as a Float. Identity pairs short-circuit to 1.0 without an HTTP call; failed requests return nil. Bumps to 0.7.0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The new get_fx_rate helpers push Stock past the previous 280-line cap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stock.get_fx_rate(from, to)wraps Yahoo's<FROM><TO>=Xquote symbol and returns just theregularMarketPriceas aFloat(ornilon error).1.0without an HTTP call.Why
Phase 2 of multi-currency in dividend-portfolio needs an FX lookup that lives outside the existing
get_quotepipeline — callingget_quote("EURUSD=X")works but pulls a full quote hash for one field, and on the downstream side would haveBaseProvider#store_stock_datacreating junkStockrows forEURUSD=X.Test plan
bundle exec rspec— 71 examples, 0 failures (7 new cases on the FX helper).bundle exec rubocop— clean.🤖 Generated with Claude Code