Add ESP32-E22 review and fix sSDR compatibility notes on the M.2 modules page#421
Open
munzzyy wants to merge 1 commit into
Open
Add ESP32-E22 review and fix sSDR compatibility notes on the M.2 modules page#421munzzyy wants to merge 1 commit into
munzzyy wants to merge 1 commit into
Conversation
…les page Signed-off-by: Cole Munz <colemunz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #405.
I looked into the ESP32-E22 to answer the issue. It's a real, certified part (Espressif's product page, the Wi-Fi CERTIFIED 6E announcement), and the Linux driver is genuinely open source (espressif/esp32e22-linux-driver). But I couldn't confirm it fits our M.2 port. Espressif's module page lists SDIO 3.0 as one of the ESP32-E22-M2-1's host interfaces, and SDIO only exists on Key E sockets, not Key B. Espressif hasn't published the module's actual key type, but I couldn't find a single SDIO-capable Wi-Fi/Bluetooth M.2 card that isn't Key E, so I wrote the entry as "unconfirmed, probably doesn't fit" rather than adding it to the list outright. The driver currently uses PCIe for Wi-Fi and USB for Bluetooth, which are both wired on Key B, so a Key B variant of this module would likely work if one ever ships.
While I was in there I also fixed the sSDR listing. It's named as an SDR example with a plain crowdsupply link and no caveats, but per Wavelet Lab's own docs, the current Rev3 is Key M and can't physically go into our Key B slot, and Rev2 is B+M so it fits mechanically but only gets a single PCIe lane out of the two it wants. Left the USB 2.0 path in as the one part that works cleanly on both revisions.