Fix charger and fuel gauge part numbers to match the shipped hardware#422
Open
munzzyy wants to merge 1 commit into
Open
Fix charger and fuel gauge part numbers to match the shipped hardware#422munzzyy wants to merge 1 commit into
munzzyy wants to merge 1 commit into
Conversation
Signed-off-by: Cole Munz <colemunz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two of the three mismatches from #420, the two that turned out to be provable from this org's own code.
The charger is a BQ25792: the MCU firmware ships a driver for exactly that part (
flipperone-mcu-firmware/lib/drivers/bq25792/), and the device tree in your u-boot fork declarescompatible = "ti,bq25792"(dts/upstream/src/arm64/rockchip/rk3576-flipper-one-rev-f0b0c1.dts, thecharger@6bnode). So Tech-Specs had it right and Heatsink.md's BQ25798 was the stale one.The fuel gauge is a BQ28Z620: same firmware has
lib/drivers/bq28z620/, and the DTS comment on the gauge node says it outright:compatible = "ti,bq28z610"; /* really bq28z620: tbc if we need a new compatible */. So Power-subsystem.md had it right and Tech-Specs' BQ28Z610 was stale. I left the DTS compatible string out of the docs since that's a kernel binding detail, and the pages name physical parts.I didn't touch the battery energy number (the third item in #420). The DTS gives 3100 mAh design capacity with a 6.0 to 8.65 V window, and both 22.9 Wh and 24 Wh fall out of that depending on which nominal cell voltage you use, so that one still needs a call from someone who knows the cell's rated spec.