fix: send empty file content to compiler instead of reading stale con…#520
Merged
Conversation
…tent from disk When a file is cleared (select all + delete), job.src is "" (empty string). Using !job.src treated empty string as falsy, causing the queue to read stale content from disk instead of sending the empty string to the compiler. Changed to job.src == null to only fall back to disk when src is truly absent.
Member
|
That's an amazing find. Do we want to use |
magnus-madsen
approved these changes
Feb 23, 2026
Contributor
Author
|
i think not. == checks both null and undefined, otherwise we would have to check both job.src === null ||job.src === undefined |
Member
|
Pushed-- should be in the ecosystem in 30min |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tent from disk
When a file is cleared (select all + delete), job.src is "" (empty string). Using !job.src treated empty string as falsy, causing the queue to read stale content from disk instead of sending the empty string to the compiler. Changed to job.src == null to only fall back to disk when src is truly absent.
I got claude code to look into this issue and it came up with this solution.