fix: reconcile compiler state when a folder is deleted#531
Merged
Conversation
VS Code's FileSystemWatcher does not fire onDidDelete for individual files when their parent folder is removed. This leaves stale entries in the compiler, causing phantom errors. After any file-system delete/create event, a debounced reconciliation re-scans the workspace with findFiles(), diffs against a client-side set of known URIs, and sends the appropriate add/rem notifications for any discrepancies. Also fixes a pre-existing bug where the jar watcher overwrote the pkgWatcher variable, leaking the fpkg watcher. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #402 — deleting a folder (e.g.
src/) now correctly removes its contents from the Flix compiler.FileSystemWatcherdoes not fireonDidDeletefor individual files when their parent folder is removed, leaving stale entries in the compilerapiRemUri/apiAddUrifor discrepancies.flix,.fpkg, and.jarfilespkgWatchervariable, leaking the fpkg watcherTest plan
lib/folder removes the fpkg from the compilersrc/folder in explorer → diagnostics clear correctly🤖 Generated with Claude Code