fix: stage flix.jar download to avoid Windows file locking#535
Merged
Conversation
On Windows the JVM holds a file lock on flix.jar, so replacing it mid-session fails. Download updates to flix.jar.new instead, prompt the user to reload, and rename the staged file on the next startup before the JVM starts. The changelog is deferred to after the rename so it is not lost on reload. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #534.
flix.jar, so replacing it mid-session fails with a file-locking error.flix.jar.newinstead, and the user is prompted to reload the window.flix.jar.newis renamed toflix.jar.Test plan
flix.jar(no.newstaging)flix.jar.newand show "Reload Now" prompt (no "Starting Flix" spinner).new, click "Reload Now" —.newshould be renamed to.jar, changelog shown, extension starts with new version🤖 Generated with Claude Code