Repository navigation
ci: build with Go 1.26 - #27
Merged
Merged
Conversation
CI, the release job and the Docker build pinned Go 1.25 with GOTOOLCHAIN=local, which now blocks every dependency PR: - golang.org/x/crypto 0.57.0 (#25) requires go >= 1.26, so go vet and the integration job fail before running anything. - govulncheck@latest (x/vuln v1.8.0) requires go >= 1.26, so the test job fails on its last step for any PR, not just #26. Go 1.25 also left upstream support when 1.27 shipped. go.mod keeps its 1.25.0 floor; only the toolchain that builds and checks birdy moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI, the release workflow and the Dockerfile pin Go 1.25 with
GOTOOLCHAIN=local. That now blocks both open Dependabot PRs:golang.org/x/crypto0.57.0) raises thegodirective to 1.26, sogo vetand the integration job stop atgo.mod requires go >= 1.26.0 (running go 1.25.14).modernc.org/sqlite1.59.0) fails only ongovulncheck:golang.org/x/vuln@v1.8.0 requires go >= 1.26.0. That step would fail the same way on any PR today.Go 1.25 is also out of upstream support since 1.27 shipped.
go.modkeeps itsgo 1.25.0floor; this only moves the toolchain that builds and checks birdy (CI, release binaries, container image).Verified locally with go1.26.8,
GOTOOLCHAIN=local, running the same steps asci.yml: gofmt clean,go vetok, golangci-lint v2.1.6 (built from source with 1.26) reports 0 issues,go test -race ./...passes, govulncheck finds no reachable vulnerabilities, andCGO_ENABLED=0 go build ./cmd/birdysucceeds.🤖 Generated with Claude Code