Keep ProfilePill immune to inherited text casing and tracking - #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #18. App headers commonly set
uppercase tracking-wideston the nav that wraps the account control — site's header does exactly this — and both properties inherit, so the pill would render UPPERCASE and letter-spaced in some apps and not others. That defeats the point of having one shared pill.ProfilePillnow restates the base layer's own defaults (normal-case tracking-tight) instead of accepting whatever it inherits, so it looks identical wherever it is mounted.Note the baselines move by a hair: letter-spacing declared in
emresolves against the element's own font size, while an inherited value arrives already computed at the ancestor's. Restatingtracking-tighton the pill is the typographically correct one of the two.Testing
bun run lintandbun run typecheckclean (same pre-existing warnings as Add ProfilePill component #18).#componentssnapshots changed.bun run dev: withtext-transform: uppercaseandletter-spacing: 0.1emapplied to the pill's ancestor, the pill staysnone/normaland its username keeps the exact same rendered width (45.13px before and after), while a plain sibling span in the same parent inherits both (uppercase,1.6px) — confirming the parent really was leaking and the pill now resists it.