flower-platform · cristian-spiescu · Aug 29, 2014 · Aug 29, 2014 · Sep 1, 2014 · Sep 1, 2014
diff --git a/org.flowerplatform.build/.checkstyle b/org.flowerplatform.build/.checkstyle
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<fileset-config file-format-version="1.2.0" simple-config="false">
+    <local-check-config name="Flower Platform Checkstyle" location="checkstyle/checkstyle-config.xml" type="project" description="Project-specific Configuration">
+    	<additional-data name="protect-config-file" value="false"/>
+    </local-check-config>
+    <fileset name="all" enabled="true" check-config-name="Flower Platform Checkstyle" local="true">
+        <file-match-pattern match-pattern="." include-pattern="true"/>
+    </fileset>        
+</fileset-config>
diff --git a/org.flowerplatform.build/.classpath b/org.flowerplatform.build/.classpath
@@ -3,5 +3,6 @@
 	<classpathentry kind="src" path="src"/>
 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
 	<classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER"/>
+	<classpathentry kind="lib" path="/org.flowerplatform.util/lib-from-maven/commons-io-2.4.jar"/>
 	<classpathentry kind="output" path="bin"/>
 </classpath>
diff --git a/org.flowerplatform.build/.gitignore b/org.flowerplatform.build/.gitignore
@@ -5,3 +5,4 @@
 war
 /bin
 /DO_NOT_COMMIT
+/target/
diff --git a/org.flowerplatform.build/.project b/org.flowerplatform.build/.project
@@ -15,10 +15,17 @@
 			<arguments>
 			</arguments>
 		</buildCommand>
+		<buildCommand>
+			<name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
 	</buildSpec>
 	<natures>
 		<nature>org.eclipse.m2e.core.maven2Nature</nature>
 		<nature>org.eclipse.jdt.core.javanature</nature>
+		<nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
+
 	</natures>
 	<filteredResources>
 		<filter>

diff --git a/org.flowerplatform.build/ant/license_headers/mxmlStandardHeader.txt b/org.flowerplatform.build/ant/license_headers/mxmlStandardHeader.txt
@@ -1,7 +1,7 @@
 <!-- 
 	license-start
 
-	Copyright (C) 2008 - 2013 Crispico Software, <http://www.crispico.com/>.
+	Copyright (C) 2008 - 2014 Crispico Software, <http://www.crispico.com/>.
 
 	This program is free software: you can redistribute it and/or modify
 	it under the terms of the GNU General Public License as published by

diff --git a/org.flowerplatform.build/ant/license_headers/standardHeader.txt b/org.flowerplatform.build/ant/license_headers/standardHeader.txt
@@ -1,6 +1,6 @@
 /* license-start
  * 
- * Copyright (C) 2008 - 2013 Crispico Software, <http://www.crispico.com/>.
+ * Copyright (C) 2008 - 2014 Crispico Software, <http://www.crispico.com/>.
  * 
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by

diff --git a/org.flowerplatform.build/build.properties b/org.flowerplatform.build/build.properties
@@ -59,7 +59,7 @@ airVersion = 3.2
 # buildProfiles = flex,flex-base,flex-mobile
 
 # Java plugins only
-# buildProfiles = java,java-base
+buildProfiles = java,java-base
 
 # Java plugins + Eclipse product
 buildProfiles = java,java-base,java-product

diff --git a/org.flowerplatform.build/build.xml b/org.flowerplatform.build/build.xml
@@ -139,6 +139,8 @@
 			<!-- performs build, without installing into repo (i.e. "install") -->
 			<arg value="verify" />
 
+			<arg value="checkstyle:checkstyle-aggregate" />
+
 			<!-- shows errors -->
 			<arg value="-e" />
 

diff --git a/org.flowerplatform.build/checkstyle/.gitignore b/org.flowerplatform.build/checkstyle/.gitignore
@@ -0,0 +1 @@
+/target/
diff --git a/org.flowerplatform.build/checkstyle/checkstyle-config.xml b/org.flowerplatform.build/checkstyle/checkstyle-config.xml
@@ -0,0 +1,195 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+    "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
+    "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
+
+<module name="Checker">
+	<property name="severity" value="warning"/>
+
+	<!-- Filters:  http://checkstyle.sourceforge.net/config.html-->
+	<module name="SuppressionCommentFilter"/>
+
+	<module name="SuppressionFilter">
+	    <property name="file" value="${config_loc}/suppressions.xml"/>
+	</module>
+
+    <!-- Checks whether files end with a new line.                        -->
+    <!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile -->
+    <module name="NewlineAtEndOfFile">
+        <property name="severity" value="ignore"/>
+    </module>
+
+    <!-- Checks that property files contain the same keys.         -->
+    <!-- See http://checkstyle.sf.net/config_misc.html#Translation -->
+    <module name="Translation"/>
+
+    <!-- Checks for Size Violations.                    -->
+    <!-- See http://checkstyle.sf.net/config_sizes.html -->
+<!--     <module name="FileLength"/>
+ -->    
+    <!-- Checks for whitespace                               -->
+    <!-- See http://checkstyle.sf.net/config_whitespace.html -->
+    <module name="FileTabCharacter">
+        <property name="severity" value="ignore"/>
+    </module>
+
+    <!-- Miscellaneous other checks.                   -->
+    <!-- See http://checkstyle.sf.net/config_misc.html -->
+    <module name="RegexpSingleline">
+       <property name="severity" value="ignore"/>
+       <property name="format" value="\s+$"/>
+       <property name="minimum" value="0"/>
+       <property name="maximum" value="0"/>
+       <property name="message" value="Line has trailing spaces."/>
+    </module>
+
+    <module name="TreeWalker">
+        <property name="tabWidth" value="4"/>
+
+		<!-- Filters : see http://checkstyle.sourceforge.net/config.html -->
+		<module name="FileContentsHolder"/>
+
+        <!-- Checks for Javadoc comments.                     -->
+        <!-- See http://checkstyle.sf.net/config_javadoc.html -->
+        <module name="JavadocType">
+   			<property name="authorFormat" value="\S"/>
+   			<property name="scope" value="package"/>
+   			<property name="allowMissingParamTags" value="true"/>
+		</module>
+		<module name="JavadocMethod">
+  			<property name="scope" value="package"/>
+  			<property name="allowMissingParamTags" value="true"/>
+  			<property name="allowMissingReturnTag" value="true"/>
+  			<property name="allowMissingThrowsTags" value="true"/>
+  			<!-- <property name="allowThrowsTagsForSubclasse" value="true"/> -->
+  			<property name="allowMissingPropertyJavadoc" value="true"/>
+		</module>
+
+        <!-- Checks for Naming Conventions.                  -->
+        <!-- See http://checkstyle.sf.net/config_naming.html -->
+        <module name="ConstantName"/>
+        <module name="LocalFinalVariableName"/>
+        <module name="LocalVariableName"/>
+        <module name="MemberName"/>
+        <module name="MethodName"/>
+        <module name="PackageName"/>
+        <module name="ParameterName"/>
+        <module name="StaticVariableName"/>
+        <module name="TypeName"/>
+
+
+        <!-- Checks for Headers                                -->
+        <!-- See http://checkstyle.sf.net/config_header.html   -->
+        <!-- <module name="Header">                            -->
+            <!-- The follow property value demonstrates the ability     -->
+            <!-- to have access to ANT properties. In this case it uses -->
+            <!-- the ${basedir} property to allow Checkstyle to be run  -->
+            <!-- from any directory within a project. See property      -->
+            <!-- expansion,                                             -->
+            <!-- http://checkstyle.sf.net/config.html#properties        -->
+            <!-- <property                                              -->
+            <!--     name="headerFile"                                  -->
+            <!--     value="${basedir}/java.header"/>                   -->
+        <!-- </module> -->
+
+        <!-- Following interprets the header file as regular expressions. -->
+        <!-- <module name="RegexpHeader"/>                                -->
+
+
+        <!-- Checks for imports                              -->
+        <!-- See http://checkstyle.sf.net/config_import.html -->
+        <module name="AvoidStarImport"/>
+        <module name="IllegalImport"/> <!-- defaults to sun.* packages -->
+        <module name="RedundantImport"/>
+        <module name="UnusedImports"/>
+
+
+        <!-- Checks for Size Violations.                    -->
+        <!-- See http://checkstyle.sf.net/config_sizes.html -->
+        <module name="LineLength">
+    		<property name="max" value="180"/>
+    		<property name="ignorePattern" value="^ *\* *[^ ]+$"/>
+		</module>
+        <module name="MethodLength">
+   			<property name="tokens" value="METHOD_DEF"/>
+   			<property name="max" value="300"/>
+   			<property name="countEmpty" value="false"/>
+		</module>
+        <module name="ParameterNumber"/>
+
+
+        <!-- Checks for whitespace                               -->
+        <!-- See http://checkstyle.sf.net/config_whitespace.html -->
+        <module name="EmptyForIteratorPad"/>
+        <module name="MethodParamPad"/>
+        <module name="NoWhitespaceAfter">
+            <property name="tokens" value="BNOT,DEC,DOT,INC,LNOT,UNARY_MINUS,UNARY_PLUS"/>
+        </module>
+        <module name="NoWhitespaceBefore"/>
+        <module name="OperatorWrap"/>
+        <module name="ParenPad"/>
+        <module name="TypecastParenPad"/>
+        <module name="WhitespaceAfter"/>
+        <module name="WhitespaceAround">
+            <property name="tokens" value="ASSIGN,BAND,BAND_ASSIGN,BOR,BOR_ASSIGN,BSR,BSR_ASSIGN,BXOR,BXOR_ASSIGN,COLON,DIV,DIV_ASSIGN,EQUAL,GE,GT,LAND,LCURLY,LE,LITERAL_ASSERT,LITERAL_CATCH,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_RETURN,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,LOR,LT,MINUS,MINUS_ASSIGN,MOD,MOD_ASSIGN,NOT_EQUAL,PLUS,PLUS_ASSIGN,QUESTION,RCURLY,SL,SLIST,SL_ASSIGN,SR,SR_ASSIGN,STAR,STAR_ASSIGN,LITERAL_ASSERT,TYPE_EXTENSION_AND,WILDCARD_TYPE"/>
+        </module>
+        <module name="GenericWhitespace"/>
+
+
+        <!-- Modifier Checks                                    -->
+        <!-- See http://checkstyle.sf.net/config_modifiers.html -->
+        <module name="ModifierOrder"/>
+        <module name="RedundantModifier"/>
+
+
+        <!-- Checks for blocks. You know, those {}'s         -->
+        <!-- See http://checkstyle.sf.net/config_blocks.html -->
+        <module name="AvoidNestedBlocks"/>
+        <module name="EmptyBlock"/>
+        <module name="LeftCurly"/>
+        <module name="NeedBraces"/>
+        <module name="RightCurly"/>
+
+
+        <!-- Checks for common coding problems               -->
+        <!-- See http://checkstyle.sf.net/config_coding.html -->
+        <module name="EmptyStatement"/>
+        <module name="EqualsHashCode"/>
+        <module name="HiddenField">
+    		<property name="ignoreSetter" value="true"/>
+    		<property name="ignoreConstructorParameter" value="true"/>
+		</module>
+        <module name="IllegalInstantiation"/>
+        <module name="InnerAssignment"/>
+      <!--   <module name="MagicNumber"/> -->
+        <module name="MissingSwitchDefault"/>
+        <module name="RedundantThrows">
+            <property name="logLoadErrors" value="true"/>
+            <property name="suppressLoadErrors" value="true"/>
+            <property name="allowUnchecked" value="true"/>
+        </module>
+        <module name="SimplifyBooleanExpression"/>
+        <module name="SimplifyBooleanReturn"/>
+        <module name="StringLiteralEquality"/>
+
+        <!-- Checks for class design                         -->
+        <!-- See http://checkstyle.sf.net/config_design.html -->
+        <!-- <module name="DesignForExtension"/> -->
+        <module name="FinalClass"/>
+        <module name="HideUtilityClassConstructor"/>
+        <module name="InterfaceIsType"/>
+      <!--   <module name="VisibilityModifier"/> -->
+
+
+        <!-- Miscellaneous other checks.                   -->
+        <!-- See http://checkstyle.sf.net/config_misc.html -->
+        <module name="ArrayTypeStyle"/>
+     <!--    <module name="FinalParameters"/> -->
+        <module name="TodoComment">
+            <property name="severity" value="ignore"/>
+        </module>
+        <module name="UpperEll"/>
+
+    </module>
+
+</module>
diff --git a/org.flowerplatform.build/checkstyle/pom.xml b/org.flowerplatform.build/checkstyle/pom.xml
@@ -0,0 +1,7 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <groupId>org.flowerplatform</groupId>
+  <artifactId>checkstyle-config</artifactId>
+  <version>1.0</version>
+  <name>Check Tools</name>
+</project>
diff --git a/org.flowerplatform.build/checkstyle/suppressions.xml b/org.flowerplatform.build/checkstyle/suppressions.xml
@@ -0,0 +1,9 @@
+<?xml version="1.0"?>
+
+<!DOCTYPE suppressions PUBLIC
+"-//Puppy Crawl//DTD Suppressions 1.1//EN"
+"http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
+
+<suppressions>
+	<suppress checks="." files="tests[\\/].*[\\/]resources[\\/]"/>
+</suppressions>
diff --git a/org.flowerplatform.build/pom.xml b/org.flowerplatform.build/pom.xml
@@ -35,6 +35,9 @@
 		</profile>
 	</profiles>
 
+	<modules>
+		    <module>checkstyle</module>
+	</modules>
 	<dependencies>
 		<dependency>
 			<groupId>org.apache.ant</groupId>
@@ -49,4 +52,31 @@
 			<scope>provided</scope>
 		</dependency>
 	</dependencies>
+
+	<build>
+	<sourceDirectory>src</sourceDirectory>
+
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
+        <version>2.12.1</version>
+        <configuration>
+        	<configLocation>checkstyle/checkstyle-config.xml</configLocation>     	
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
+   <reporting>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
+        <version>2.12.1</version>
+        <configuration>
+        	<configLocation>checkstyle/checkstyle-config.xml</configLocation>       	
+        </configuration> 
+      </plugin>
+    </plugins>
+  </reporting>
 </project>
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,3 +5,4 @@ @@
     war
     /bin
     /DO_NOT_COMMIT
+    /target/