Skip to content

refactor: remove the default timeout for executables#239

Merged
jahvon merged 1 commit into
mainfrom
timeout
Jun 20, 2025
Merged

refactor: remove the default timeout for executables#239
jahvon merged 1 commit into
mainfrom
timeout

Conversation

@jahvon

@jahvon jahvon commented Jun 20, 2025

Copy link
Copy Markdown
Member

Removed the default value (30m0s) for the Timeout field in flowfile_schema.json and flowfile.md. This aligns with the new approach of treating Timeout as optional.

@codecov

codecov Bot commented Jun 20, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 21.91%. Comparing base (b944b8c) to head (946a89e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
types/executable/executable.go 25.00% 2 Missing and 1 partial ⚠️
internal/cache/executable_generator.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   22.07%   21.91%   -0.16%     
==========================================
  Files          84       84              
  Lines        6958     7026      +68     
==========================================
+ Hits         1536     1540       +4     
- Misses       5145     5208      +63     
- Partials      277      278       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jahvon jahvon merged commit 127ca04 into main Jun 20, 2025
10 checks passed
@jahvon jahvon deleted the timeout branch June 20, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant