Integrate an output comparison method for mpeg2 video decoder#256
Merged
Conversation
rsanchez87
force-pushed
the
COM-13022
branch
4 times, most recently
from
ec72471 to
91eeb85
Compare
Contributor
Author
mdimopoulos
requested changes
Apr 8, 2025
Contributor
mdimopoulos
left a comment
mdimopoulos
left a comment
There was a problem hiding this comment.
I have a few suggestions for changes and some questions, see individual comments.
Apart from that also
- add gstreamer's standard mpeg2v decoder https://gstreamer.freedesktop.org/documentation/mpeg2dec/index.html?gi-language=c
- if you haven't done regression tests with an ffmpeg and gstreamer decoder (other than mpeg2) i suggest you do, there is risk of regressions in this PR
- at least 1 of the commits should be of type
featsince we are adding a new comparison method - at the end remember to add relevant information to the docs as well as build-related files (pyproject.toml)
rsanchez87
force-pushed
the
COM-13022
branch
2 times, most recently
from
2dbdf9a to
d721987
Compare
mdimopoulos
approved these changes
Apr 9, 2025
rsanchez87
force-pushed
the
COM-13022
branch
2 times, most recently
from
987238f to
5f7f600
Compare
ylatuya
requested changes
Apr 9, 2025
Contributor
ylatuya
left a comment
ylatuya
left a comment
There was a problem hiding this comment.
Besides the comments, you should also add a new mpeg check test suite for the tests https://github.com/fluendo/fluster/tree/master/check
rsanchez87
force-pushed
the
COM-13022
branch
6 times, most recently
from
943c014 to
55c8788
Compare
ylatuya
reviewed
Apr 10, 2025
ylatuya
reviewed
Apr 10, 2025
ylatuya
reviewed
Apr 10, 2025
ylatuya
reviewed
Apr 10, 2025
ylatuya
reviewed
Apr 10, 2025
rsanchez87
force-pushed
the
COM-13022
branch
2 times, most recently
from
b779962 to
8b954ad
Compare
ylatuya
reviewed
Apr 12, 2025
ylatuya
reviewed
Apr 12, 2025
ylatuya
reviewed
Apr 14, 2025
ylatuya
reviewed
Apr 14, 2025
ylatuya
reviewed
Apr 14, 2025
ylatuya
reviewed
Apr 16, 2025
ylatuya
reviewed
Apr 16, 2025
ylatuya
reviewed
Apr 16, 2025
ylatuya
reviewed
Apr 16, 2025
ylatuya
reviewed
Apr 16, 2025
| ctx.verbose, | ||
|
|
||
| if self.test_method == TestMethod.PIXEL: | ||
| reference_decoder = get_reference_decoder_for_codec(ctx.decoder.codec) |
Contributor
There was a problem hiding this comment.
This should be checked only once for the test suite instead of doing the check for every test vector. It should also not raise an exception since this will stop running the rest of the test suites.
This must be handled in the run function where the decoder to test is also checked: https://github.com/fluendo/fluster/blob/COM-13022/fluster/test_suite.py#L515
| decoder.multiple_layers = True | ||
| if decoder.codec != test_suite.codec: | ||
| continue | ||
| if test_suite.test_method == TestMethod.PIXEL and decoder.is_reference is True: |
Contributor
There was a problem hiding this comment.
Suggested change
| if test_suite.test_method == TestMethod.PIXEL and decoder.is_reference is True: | |
| if test_suite.test_method == TestMethod.PIXEL and decoder.is_reference: |
rsanchez87
force-pushed
the
COM-13022
branch
2 times, most recently
from
efe9e14 to
4b3477d
Compare
…entical outputs -Old codecs like MPEG-2 Video do not use a standarized IDCT (MPEG-C Part1) causing mismatches in the generated output. -This new method allows creating tests suites that will compare the output pixel by pixel with a tolerance range
ylatuya
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.